Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable dynamic log file #7102

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Disable dynamic log file #7102

merged 1 commit into from
Apr 12, 2024

Conversation

yinggeh
Copy link
Contributor

@yinggeh yinggeh commented Apr 11, 2024

Disable dynamic log file location, aka --log_file API.

@yinggeh yinggeh requested a review from mc-nv April 11, 2024 18:09
@yinggeh yinggeh self-assigned this Apr 11, 2024
@mc-nv
Copy link
Contributor

mc-nv commented Apr 11, 2024

This change doesn't look like a cherry-pick from main?
Was it tested?

@yinggeh yinggeh changed the title Disable dynamic logging location Disable dynamic log file Apr 11, 2024
@yinggeh
Copy link
Contributor Author

yinggeh commented Apr 11, 2024

@mc-nv Here is the PR merged to main. #7092

@mc-nv mc-nv merged commit 0d61b40 into r24.04 Apr 12, 2024
3 checks passed
@mc-nv mc-nv deleted the r24.04-yinggeh-disable-dynamic-log-file-cp branch April 12, 2024 19:11
rmccorm4 added a commit that referenced this pull request Apr 18, 2024
@rmccorm4
Revert "Disable dynamic logging location (#7102)"
1a31d96 
This reverts commit 0d61b40.
mc-nv pushed a commit that referenced this pull request Apr 19, 2024
@rmccorm4 @mc-nv
Revert "Disable dynamic logging location (#7102)"
b23db16 
This reverts commit 0d61b40.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mc-nv mc-nv mc-nv approved these changes

Assignees

@yinggeh yinggeh

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yinggeh @mc-nv