-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate system shared memory region size when registering a region #7093
Conversation
Added tests for system shm registration to L0_shared_memory.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Small, non blocking items: I also thought while reading that Another small tweak could be to wrap the validation into a function:
These are all minor - and non blocking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TM,LG! 🚀
This PR:
Deferred to separate PRs:
shm_open
)ref: DLIS-6198