Fix html image rendering in sphinx documentation #7084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indrajit96
previously approved these changes
Apr 8, 2024
tanmayv25
force-pushed
the
tanmayv-html-img
branch
from
3a90565 to
9008af5
Compare
indrajit96
approved these changes
Apr 8, 2024
yinggeh
reviewed
Apr 8, 2024
There was a problem hiding this comment.
Can you also update conf.py copyright to 2024? Thanks.
There was a problem hiding this comment.
Can you also do the followings? I commited a change on your branch but looks like you just pushed with -f. Thanks.
- remove comments in line 330-332
- remove "1. " in line 326
- fix indentations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MyST can be used to support the html image links in the documentation.
Please read about the extension here: https://myst-parser.readthedocs.io/en/latest/syntax/images_and_figures.html
With this change the html images are rendered properly in the docs.
Before
After