Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix busyop test for L0_memory_growth #6900

Merged
merged 4 commits into from
Feb 22, 2024
Merged

Fix busyop test for L0_memory_growth #6900

merged 4 commits into from
Feb 22, 2024

Conversation

krishung5
Copy link
Contributor

@krishung5 krishung5 commented Feb 21, 2024

  • Replaced the graphdef_busyop model with a simple Python model with a sleep function to intentionally cause memory growth caught by Massif (The TF busyop models are still used in the L0_custom_ops test so didn't remove them)
  • Specified the concurrency parameter in http client so that the async requests are sent without being blocked, which was the reason why we couldn't see the growth before. See here for more details.

Expected massif output should be something like:

Test Duration: 00:01:39 (HH:MM:SS)
--------------------------------------------------------------------------------
Command:            /opt/tritonserver/bin/tritonserver --model-repository=/opt/tritonserver/qa/L0_memory_growth/test_repo
Massif arguments:   --time-unit=B --massif-out-file=test_busyop.massif
ms_print arguments: test_busyop.massif
--------------------------------------------------------------------------------


    GB
6.130^                                                ##                      
     |                                               @# :::                   
     |                                             @@@# :: :                  
     |                                          @@@@ @# :: ::                 
     |                                        ::@ @@ @# :: ::                 
     |                                      ::::@ @@ @# :: ::::               
     |                                  @@@@: ::@ @@ @# :: ::: :              
     |                                @@@ @ : ::@ @@ @# :: ::: :              
     |                              ::@@@ @ : ::@ @@ @# :: ::: :::            
     |                             :: @@@ @ : ::@ @@ @# :: ::: :: ::          
     |                           @@:: @@@ @ : ::@ @@ @# :: ::: :: :           
     |                          @@ :: @@@ @ : ::@ @@ @# :: ::: :: : :         
     |                         @@@ :: @@@ @ : ::@ @@ @# :: ::: :: : :::       
     |                       @@@@@ :: @@@ @ : ::@ @@ @# :: ::: :: : ::        
     |                      :@ @@@ :: @@@ @ : ::@ @@ @# :: ::: :: : :: :      
     |                  :::::@ @@@ :: @@@ @ : ::@ @@ @# :: ::: :: : :: ::     
     |                :::  ::@ @@@ :: @@@ @ : ::@ @@ @# :: ::: :: : :: ::@@   
     |            :::::::  ::@ @@@ :: @@@ @ : ::@ @@ @# :: ::: :: : :: ::@    
     |       @::::::: :::  ::@ @@@ :: @@@ @ : ::@ @@ @# :: ::: :: : :: ::@ :  
     |   ::::@: : ::: :::  ::@ @@@ :: @@@ @ : ::@ @@ @# :: ::: :: : :: ::@ :: 
   0 +----------------------------------------------------------------------->GB
     0                                                                   21.24

Number of snapshots: 50
 Detailed snapshots: [5, 16, 17, 18, 19, 22, 23, 24, 25, 29, 30, 31, 32, 33 (peak), 46]

--------------------------------------------------------------------------------

@krishung5 krishung5 changed the title FIx up busyop test for L0_memory_growth Fix busyop test for L0_memory_growth Feb 21, 2024
Copy link
Contributor

@rmccorm4 rmccorm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes Kris! Looking forward to to this subtest passing consistently now!

Only minor comments

qa/L0_memory_growth/busy_op_test.py Outdated Show resolved Hide resolved
qa/python_models/busy_op/config.pbtxt Outdated Show resolved Hide resolved
@krishung5 krishung5 requested a review from rmccorm4 February 21, 2024 19:58
Copy link
Contributor

@rmccorm4 rmccorm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚀

@krishung5 krishung5 merged commit 5732163 into main Feb 22, 2024
3 checks passed
@krishung5 krishung5 deleted the krish-busy-op branch February 22, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants