Nuke onnx models from test #6890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mc-nv
previously approved these changes
Feb 16, 2024
mc-nv
reviewed
Feb 17, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| plan_name = tu.get_model_name("plan", np.float32, np.float32, np.float32) | ||
|
|
||
| ensemble_prefix = "simple_" | ||
| onnx_ensemble_name = ensemble_prefix + onnx_name | ||
| graphdef_ensemble_name = ensemble_prefix + graphdef_name |
Check notice
Code scanning / CodeQL
Unused local variable Note
mc-nv
approved these changes
Feb 22, 2024
pvijayakrish
pushed a commit
that referenced
this pull request
Jan 15, 2025
* Elimitated usage of onnx models in tests/ disabled some tests * Verified green: batch 1 * Verified tests: batch 2 * Verified tests: batch 3 * Verified tests: batch 4 * Verified tests: batch 5 * Verified tests: batch 6 * Verified tests: batch 7 * Verified tests: batch 8 * Verified tests: batch 9 * Verified tests: batch 10 * Verified tests: batch 11 * Verified tests: batch 12 * Verified tests: batch 12_follow up * Verified tests: batch 13 * Verified tests: batch 14 * Verified tests: batch 15 * Verified tests: batch 16 * Removed exits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I disabled some onnx tests, but mostly replaced
onnxmodels withlibtorchmodels.The only question left with L0_mlflow. I don't know as of now if
onnxmodels are required for this test or not.If yes, we should probably disable this test.