Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match forward headers case insensitively. #6889

Merged
merged 16 commits into from
Feb 27, 2024
Merged

Match forward headers case insensitively. #6889

merged 16 commits into from
Feb 27, 2024

Conversation

yinggeh
Copy link
Contributor

@yinggeh yinggeh commented Feb 16, 2024

Currently, headers are lowercased before they are sent to the server, which causes inconvenience. According to HTTP specification header names are case-insensitive. Therefore, the forward header pattern (regex) should match the header case insensitively.

@yinggeh yinggeh requested review from rmccorm4 and GuanLuo February 16, 2024 04:22
@yinggeh yinggeh self-assigned this Feb 16, 2024
rmccorm4
rmccorm4 reviewed Feb 16, 2024
View reviewed changes
qa/L0_parameters/test.sh Outdated Show resolved Hide resolved
@yinggeh yinggeh requested a review from Tabrizian February 16, 2024 23:39
GuanLuo
GuanLuo reviewed Feb 20, 2024
View reviewed changes
TRITON_VERSION Outdated Show resolved Hide resolved
docs/protocol/extension_statistics.md Outdated Show resolved Hide resolved
qa/L0_parameters/parameters_test.py Outdated Show resolved Hide resolved
qa/L0_response_statistics/test.sh Outdated Show resolved Hide resolved
qa/L0_parameters/parameters_test.py Outdated Show resolved Hide resolved
src/grpc/grpc_server.cc Outdated Show resolved Hide resolved
@yinggeh yinggeh mentioned this pull request Feb 20, 2024
Closed
@yinggeh yinggeh force-pushed the yinggeh-DLIS-5448-request-header branch from 84b78ba to d06f732 Compare February 21, 2024 00:20
rmccorm4
rmccorm4 reviewed Feb 23, 2024
View reviewed changes
qa/L0_parameters/test.sh Outdated Show resolved Hide resolved
@yinggeh yinggeh requested review from rmccorm4 and GuanLuo February 23, 2024 23:32
rmccorm4
rmccorm4 reviewed Feb 26, 2024
View reviewed changes
Copy link
Contributor

@rmccorm4 rmccorm4 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than minor doc/comment changes. Don't need to re-run pipeline again for these changes

@yinggeh yinggeh requested a review from rmccorm4 February 26, 2024 21:51
@yinggeh yinggeh requested a review from rmccorm4 February 26, 2024 22:11
@yinggeh yinggeh merged commit 5630efe into main Feb 27, 2024
3 checks passed
@yinggeh yinggeh deleted the yinggeh-DLIS-5448-request-header branch February 27, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmccorm4 rmccorm4 rmccorm4 approved these changes

@Tabrizian Tabrizian Awaiting requested review from Tabrizian

@GuanLuo GuanLuo Awaiting requested review from GuanLuo

Assignees

@yinggeh yinggeh

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yinggeh @rmccorm4 @GuanLuo