Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test reports to L0_dlpack_multi_gpu and L0_warmup #6873

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

krishung5
Copy link
Contributor

@krishung5 krishung5 commented Feb 12, 2024

Adding unit test reports to L0_dlpack_multi_gpu and L0_warmup to also fix the test failures as we removed the use of check_test_results for python_unittest.py and it was used in these tests as well.

@krishung5 krishung5 requested a review from rmccorm4 February 12, 2024 20:45
@krishung5 krishung5 marked this pull request as ready for review February 12, 2024 20:45
rmccorm4
rmccorm4 previously approved these changes Feb 12, 2024
Copy link
Contributor

@rmccorm4 rmccorm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 🚀

@krishung5 krishung5 changed the title Add unit test reports to L0_dlpack_multi_gpu Add unit test reports to L0_dlpack_multi_gpu and L0_warmup Feb 12, 2024
@krishung5
Copy link
Contributor Author

@rmccorm4 Just found out L0_warmup is using the python_unittest.py as well, need your review on that file. I think these tests should be all the ones that are using the unit test script. Thanks!

@krishung5 krishung5 requested a review from rmccorm4 February 12, 2024 22:46
@krishung5 krishung5 merged commit c048a9f into main Feb 14, 2024
3 checks passed
@krishung5 krishung5 deleted the krish-fix-dlpack branch February 14, 2024 18:19
krishung5 added a commit that referenced this pull request Feb 14, 2024
* Add unit test reports to L0_dlpack_multi_gpu

* Add unit test reports to L0_warmup
mc-nv pushed a commit that referenced this pull request Feb 15, 2024
…6881)

* Add unit test reports to L0_dlpack_multi_gpu

* Add unit test reports to L0_warmup
pvijayakrish pushed a commit that referenced this pull request Jan 15, 2025
…6881)

* Add unit test reports to L0_dlpack_multi_gpu

* Add unit test reports to L0_warmup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants