Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --metrics-address to specify a listening address specifically for the metrics server #4747

Conversation

OvervCW
Copy link

@OvervCW OvervCW commented Aug 8, 2022

Currently both the HTTP API and Prometheus metrics server listen on the same address specified using --http-address, but there are scenarios where you may want to expose the HTTP API only on localhost, and make the metrics more publicly accessible for Prometheus to scrape.

The existing implementation also prevents you from changing the address of the metrics server if the HTTP API is disabled (TRITON_ENABLE_HTTP unset), since the --http-address flag is not available in that case.

This PR introduces a new command line parameter --metrics-address that allows you to specify an address specifically for the Prometheus metrics server, which may be different from the --http-address.

I've implemented it to not be a breaking change; if you only specify --http-address without --metrics-address then the metrics server will listen on the same address as the HTTP server, just like the existing behavior.

@rmccorm4
Copy link
Contributor

CC @tanmayv25 this idea seams reasonable to me, what do you think?

PR might need a couple tweaks and we'll need a signed CLA otherwise.

@rmccorm4
Copy link
Contributor

rmccorm4 commented May 4, 2023

Hi @OvervCW, for simplicity since we didn't receive a CLA and recently had some major changes around the structure of main.cc, I've filed a similar PR here to add this functionality: #5737. Sorry for the delay on this!

@rmccorm4 rmccorm4 closed this May 4, 2023
@OvervCW
Copy link
Author

OvervCW commented May 5, 2023

@rmccorm4 Fair enough, but my company did submit a CLA for a different PR: triton-inference-server/core#122

@rmccorm4
Copy link
Contributor

rmccorm4 commented May 5, 2023

My apologies @OvervCW, we do appreciate the contribution nonetheless!

For future PRs please do let us know that a CLA was already submitted, as it helps the team verify more quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants