Skip to content

Commit

Permalink
Update comments
Browse files Browse the repository at this point in the history
  • Loading branch information
krishung5 committed May 7, 2024
1 parent 04711b2 commit b55d343
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/shared_memory_manager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ OpenCudaIPCRegion(
cudaError_t err = cudaIpcOpenMemHandle(
data_ptr, *cuda_shm_handle, cudaIpcMemLazyEnablePeerAccess);
if (err != cudaSuccess) {
// Should not pass the detailed error message back to the client.
// Log detailed error message
LOG_ERROR << "failed to open CUDA IPC handle: " << cudaGetErrorString(err);
return TRITONSERVER_ErrorNew(
TRITONSERVER_ERROR_INVALID_ARG,
Expand Down Expand Up @@ -296,7 +296,7 @@ CheckCudaSharedMemoryRegionSize(
// User-provided offset and byte_size should not go out-of-bounds.
if (err != nullptr || byte_size > shm_region_size) {
if (err != nullptr) {
// Should not pass the detailed error message back to the client.
// Log detailed error message
LOG_ERROR << TRITONSERVER_ErrorMessage(err);
TRITONSERVER_ErrorDelete(err);
}
Expand Down

0 comments on commit b55d343

Please sign in to comment.