OpenVINO 2023.3.0 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 14, 2024
|
pre-commit failure unrelated to this change |
tools/gen_openvino_dockerfile.py
Outdated
| @@ -123,37 +123,19 @@ def dockerfile_for_windows(output_file): | |||
| df += """ | |||
| SHELL ["cmd", "/S", "/C"] | |||
|
|
|||
| # Build instructions: | |||
| # https://github.com/openvinotoolkit/openvino/wiki/BuildingForWindows | |||
| # instructions: | |||
There was a problem hiding this comment.
Can you make a note that we are building from source for linux but installing from the openvino repository for windows? @nnshah1 I would like your opinion on whether there should be a follow up ticket to revisit this installation fracture?
There was a problem hiding this comment.
nv-kmcgill53
approved these changes
Feb 14, 2024
Merged
mc-nv
pushed a commit
that referenced
this pull request
Feb 15, 2024
* Use OV archive * Note linux is building from source while windows is using archive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs: