Fix handling of newlines in classed HTML #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The examples used the `_newlines` syntax without providing newlines leading to broken highlighting (#303). The function for producing classed HTML added newlines for you so I deprecated that one and added a new one which doesn't, so that I could change the examples to use the `_newlines` variant in the proper way.
src/html.rs
Outdated
| /// | ||
| /// let syntax_set = SyntaxSet::load_defaults_newlines(); | ||
| /// let syntax_set = SyntaxSet::load_defaults_nonewlines(); |
There was a problem hiding this comment.
Is this right? IIUC, either this needs to change, or the code feeding the HTML generator needs to change, but not both?
There was a problem hiding this comment.
Took me a while to get around to this but you're very right thanks for catching this.
|
That nit aside, LVGTM - it fixed a mis-highlighting that I'd been meaning to get around to investigating for a while now, which is handy indeed! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The examples used the
_newlinessyntax without providing newlines,leading to occasional broken highlighting (#303). The function for producing
classed HTML added newlines for you so I deprecated that one and
added a new one which doesn't, so that I could change the examples to
use the
_newlinesvariant in the proper way.cc @mitnk @uwearzt @quasicomputational