Add support for metadata 'shellVariables' #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmyr
force-pushed
the
feature/metadata-shellvars
branch
from
a167f38 to
4e0ee36
Compare
trishume
reviewed
Nov 11, 2018
| pub line_comment: Option<String>, | ||
| /// The first pair of `TM_COMMENT_START` and `TM_COMMENT_END` items in | ||
| /// `shell_variables`, if they exist. | ||
| pub block_comment: Option<(String, String)>, |
There was a problem hiding this comment.
Since all the fields are public, can you add a private field below this that's like
__allow_adding_fields_without_major_semver_bump: (),There was a problem hiding this comment.
Ah interesting, hadn't thought of that. done.
cmyr
force-pushed
the
feature/metadata-shellvars
branch
from
4e0ee36 to
7ccdb70
Compare
This adds loading of `shellVariable` metadata, and includes convenience access to comment related fields.
cmyr
force-pushed
the
feature/metadata-shellvars
branch
from
7ccdb70 to
fcf5e03
Compare
|
This is rebased and (hopefully) ready to go. |
trishume
approved these changes
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes commits from #223; I'll rebase when that gets in. The only new commit here is a167f38.