Don't set prototype for prototype contexts included via direct reference #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a SyntaxSet is built once, all the references are replaced by direct references (via index). When it's converted back to a builder and then built again, the code that marks prototypes needs to handle those references too, otherwise some contexts include the prototype when they should not. Fixes #219.
keith-hall
approved these changes
Oct 18, 2018
|
@trishume any chance you can publish a 3.0.2 with the current master? Some nice bugfixes in there :) |
|
@Keats done, I published |
|
Thanks!
…On Sun, 11 Nov 2018, 03:18 Tristan Hume ***@***.*** wrote:
@Keats <https://github.com/Keats> done, I published v3.0.2
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#221 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AApho6EKW9VBSGjK26xWhioDB0SzMbO4ks5ut4kAgaJpZM4Xso5E>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a SyntaxSet is built once, all the references are replaced by
direct references (via index).
When it's converted back to a builder and then built again, the code
that marks prototypes needs to handle those references too, otherwise
some contexts include the prototype when they should not.
Fixes #219.