when searching for a syntax, search in reverse order #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will prioritize those loaded last over those loaded first, in case of conflicts. As syntaxes are loaded deterministically in lexicographical order, this matches Sublime Text's behavior
robinst
reviewed
Oct 14, 2018
robinst
reviewed
Oct 15, 2018
| syntax = syntax_set.find_syntax_by_scope(Scope::new(&"source.a").unwrap()).unwrap(); | ||
| assert_eq!(syntax.name, "A improved"); | ||
| syntax = syntax_set.find_syntax_by_first_line(&"syntax a").unwrap(); | ||
| assert_eq!(syntax.name, "C"); |
robinst
approved these changes
Oct 15, 2018
trishume
approved these changes
Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will prioritize syntaxes loaded last over those loaded first when searching for a suitable syntax by any means. As syntaxes are loaded deterministically in lexicographical order, this matches Sublime Text's behavior in case of conflicts, and should allow custom syntaxes to be used in favor of "built-in" syntaxes, which is useful for #205.