Elm syntax does not compile on master anymore

[Keats]

The syntaxes are located at https://github.com/elm-community/SublimeElmLanguageSupport/tree/master/Syntaxes . I added the repo to the packages folder of master for trying it quickly.

Error message while running make packs in syntect master

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: ParseSyntax(RegexCompileError("$+(?!^ {4})", Error(-114, target of repeat operator is invalid)), Some("testdata/Packages/SublimeElmLanguageSupport/Syntaxes/Elm Compile Messages.sublime-syntax"))', libcore/result.rs:1009:5

Offending line: https://github.com/elm-community/SublimeElmLanguageSupport/blob/master/Syntaxes/Elm%20Compile%20Messages.sublime-syntax#L67

[keith-hall]

I wonder if this is related to the regex rewriting for no newlines mode, as it seems to be converting the \n to $, and as it is followed by a +, it's seen as invalid by Oniguruma.

[keith-hall]

Of course, as Sublime Text syntax grammars only operate on one line at a time, that regex pattern is fairly nonsense anyway and maybe should be fixed in the Elm repo?

[robinst]

Yeah looks like nonewlines mode. We could tweak the \n to $ rewriting some more, but fixing the grammar would also be good.

Looks like the line to tweak for the rewriting is here: https://github.com/trishume/syntect/blob/master/src/parsing/yaml_load.rs#L561

[Keats]

So the line in the grammar should be match: '(?!^ {4})' ?

[robinst]

@Keats Yeah that would make more sense I think.

[robinst]

I raised #212 to tweak the regex rewriting in syntect.

[trishume]

Can someone confirm the syntax compiles now that the fix is merged?

[Keats]

It does work