-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encourage use of lines with newline characters #196
Comments
robinst
added a commit
that referenced
this issue
Aug 6, 2018
Good idea! Raised a PR for the first point. We should also change the docs for /// Same as `load_defaults_nonewlines` but for parsing line strings with newlines at the end.
|
trishume
added a commit
that referenced
this issue
Aug 7, 2018
Add `LinesWithEndings` util for iterating over lines (#196)
trishume
added a commit
that referenced
this issue
Sep 12, 2018
Use newlines syntaxes in HTML and docs, fixes #196
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'd like to change the HTML APIs and the doc examples to use the
newlines
version of the syntax sets. Thenonewlines
version is a hack and sometimes provides incorrect results.Here's my proposed plan:
easy
orutil
module with a doc comment explaining how it lets you use thenewlines
version with strings? Stack Overflow's default license isn't compatible with me copy-pasting it AFAIK.html::highlighted_snippet_for_string
and the IO with newline reader loop inhighlighted_snippet_for_file
.newlines
version of the syntax sets as requiredThe text was updated successfully, but these errors were encountered: