Refactor QueryDataDecoder to return Iterator #24951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losipiuk
reviewed
Feb 7, 2025
client/trino-client/src/main/java/io/trino/client/ResultRows.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/closable-iterators
branch
4 times, most recently
from
77d7d5e to
716f616
Compare
losipiuk
reviewed
Feb 7, 2025
client/trino-client/src/main/java/io/trino/client/spooling/SpooledSegmentIterator.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/closable-iterators
branch
from
716f616 to
7162785
Compare
losipiuk
reviewed
Feb 7, 2025
client/trino-client/src/test/java/io/trino/client/TestResultRowsDecoder.java
Outdated
Show resolved
Hide resolved
losipiuk
approved these changes
Feb 7, 2025
Iterable<List<Object>> was an initial sin, as the assumption was that you can iterate over data multiple times, which isn't true anymore for spooled segments, which are downloaded and acknowledged once the data is fully read. Two new classes are introduced: SpooledSegmentIterator which is responsible for loading, acknowledging spooled segments, closing of the input stream for the spooled segment. This encapsulates this logic now in a single place and makes this logic reusable for other use cases. This iterator is lazy, the segment is loaded on the first row read.
wendigo
force-pushed
the
serafin/closable-iterators
branch
from
7162785 to
9e162be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iterable<List> was an initial sin, as the assumption was that you can iterate over data multiple times, which isn't true anymore for spooled segments, which are downloaded and acknowledged once the data is fully read.
Two new classes are introduced: SpooledSegmentIterator which is responsible for loading, acknowledging spooled segments, closing of the input stream for the spooled segment. This encapsulates this logic now in a single place and makes this logic reusable for other use cases. This iterator is lazy, the segment is loaded on the first row read.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: