Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support read 'p' type deletion vectors in Delta Lake #24946

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

chenjian2664
Copy link
Contributor

@chenjian2664 chenjian2664 commented Feb 7, 2025

Description

This is also a prerequirements for testing MERGE behavior with deletion vectors proposed in #24756

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

## Delta Lake
* Support read 'p' type deletion vectors in Delta Lake. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Feb 7, 2025
@chenjian2664 chenjian2664 requested a review from ebyhr February 7, 2025 03:43
@github-actions github-actions bot added the delta-lake Delta Lake connector label Feb 7, 2025
@chenjian2664 chenjian2664 requested a review from pajaks February 7, 2025 03:43
@ebyhr
Copy link
Member

ebyhr commented Feb 7, 2025

storageType = 'p' means an absolute path. https://github.com/delta-io/delta/blob/master/PROTOCOL.md#deletion-vector-descriptor-schema. A static resource-based test may not be suitable.

@chenjian2664 chenjian2664 force-pushed the delta_p_dv branch 2 times, most recently from 7614584 to e586019 Compare February 7, 2025 06:44
Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for comments.

@chenjian2664 chenjian2664 force-pushed the delta_p_dv branch 4 times, most recently from 1056a0e to e887fbe Compare February 7, 2025 11:31
@chenjian2664 chenjian2664 requested a review from ebyhr February 7, 2025 13:38
@ebyhr
Copy link
Member

ebyhr commented Feb 7, 2025

/test-with-secrets sha=075752b92f04ede70f881651230a2d1b3e3f9817

Copy link

github-actions bot commented Feb 7, 2025

The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/13208944897

@ebyhr ebyhr merged commit ec8a019 into trinodb:master Feb 7, 2025
47 checks passed
@github-actions github-actions bot added this to the 471 milestone Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed delta-lake Delta Lake connector
Development

Successfully merging this pull request may close these issues.

2 participants