Improve docs for support hadoop compatible file system when use HDFS … #24918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosabua
requested changes
Feb 6, 2025
| @@ -507,6 +507,10 @@ the property may be configured for: | |||
| - Block [data size](prop-type-data-size) for HDFS storage. | |||
| - `4MB` | |||
| - HDFS | |||
| * - `exchange.hdfs.skip-directory-scheme-validation` | |||
| - Skip directory scheme validation to support hadoop compatible file system. | |||
There was a problem hiding this comment.
Suggested change
| - Skip directory scheme validation to support hadoop compatible file system. | |
| - Skip directory scheme validation to support Hadoop-compatible file system. |
arguably "partially Hadoop-compatible" right?
| @@ -603,6 +607,19 @@ exchange-manager.name=hdfs | |||
| exchange.base-directories=hadoop-master:9000/exchange-spooling-directory | |||
| hdfs.config.resources=/usr/lib/hadoop/etc/hadoop/core-site.xml | |||
| ``` | |||
| You can enable `exchange.hdfs.skip-directory-scheme-validation` to support hadoop compatible file system. Please do the following steps: | |||
There was a problem hiding this comment.
Suggested change
| You can enable `exchange.hdfs.skip-directory-scheme-validation` to support hadoop compatible file system. Please do the following steps: | |
| You can enable `exchange.hdfs.skip-directory-scheme-validation` to support other Hadoop- compatible file systems: | |
| @@ -603,6 +607,19 @@ exchange-manager.name=hdfs | |||
| exchange.base-directories=hadoop-master:9000/exchange-spooling-directory | |||
| hdfs.config.resources=/usr/lib/hadoop/etc/hadoop/core-site.xml | |||
| ``` | |||
| You can enable `exchange.hdfs.skip-directory-scheme-validation` to support hadoop compatible file system. Please do the following steps: | |||
| 1. Configure AbstractFileSystem implementation in `core-site.xml`. | |||
There was a problem hiding this comment.
Suggested change
| 1. Configure AbstractFileSystem implementation in `core-site.xml`. | |
| 1. Configure the `AbstractFileSystem` implementation in `core-site.xml`. |
| @@ -603,6 +607,19 @@ exchange-manager.name=hdfs | |||
| exchange.base-directories=hadoop-master:9000/exchange-spooling-directory | |||
| hdfs.config.resources=/usr/lib/hadoop/etc/hadoop/core-site.xml | |||
| ``` | |||
| You can enable `exchange.hdfs.skip-directory-scheme-validation` to support hadoop compatible file system. Please do the following steps: | |||
| 1. Configure AbstractFileSystem implementation in `core-site.xml`. | |||
| 2. Put the relevant client jars into the directory `${Trino_HOME}/plugin/exchange-hdfs` on all Trino servers. | |||
There was a problem hiding this comment.
Suggested change
| 2. Put the relevant client jars into the directory `${Trino_HOME}/plugin/exchange-hdfs` on all Trino servers. | |
| 2. Add the relevant client JAR files into the directory `${Trino_HOME}/plugin/exchange-hdfs` on all Trino cluster nodes. |
| 2. Put the relevant client jars into the directory `${Trino_HOME}/plugin/exchange-hdfs` on all Trino servers. | ||
|
|
||
| The following `exchange-manager.properties` configuration example specifies Alluxio | ||
| as the spooling storage destination. |
There was a problem hiding this comment.
Suggested change
| as the spooling storage destination. | |
| as the spooling storage location. |
|
|
||
| ```properties | ||
| exchange-manager.name=hdfs | ||
| exchange.base-directories=alluxio://alluxio-master:19998/exchange-spooling-directory |
There was a problem hiding this comment.
Why is that not done via the Alluxio file system support instead of HDFS? We have to probably explain that
There was a problem hiding this comment.
Thank you for feedback. Since the HDFS client supports accessing other Hadoop-compatible file system, I believe adding this config can provide user with more options. By modifying the core-site.xml and adding the relevant client JARs, user can freely choose Hadoop-compatible file system. Different file system will require different configurations and client JARs. Here, Alluxio is only an example.
There was a problem hiding this comment.
Fair enough .. we should call that out in the written docs
There was a problem hiding this comment.
I've made the suggested changes. Please let me know if there's anything else.
hqbhoho
force-pushed
the
feature/improve_docs_for_exchange_hdfs
branch
from
27bb725 to
46c04bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #24627
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: