Document using statistics in the Faker connector #24874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nineinchnick
force-pushed
the
faker-ctas-docs
branch
from
1a0f029 to
f9ba5d6
Compare
mosabua
requested changes
Feb 3, 2025
This was referenced Feb 3, 2025
nineinchnick
force-pushed
the
faker-ctas-docs
branch
from
f9ba5d6 to
9c9a921
Compare
mosabua
reviewed
Feb 4, 2025
| can be used: | ||
|
|
||
| ```sql | ||
| CREATE TABLE generator.default.customer AS TABLE production.public.customer; |
There was a problem hiding this comment.
yeah .. I still have to document the TABLE keyword somewhere as well...
mosabua
reviewed
Feb 4, 2025
mosabua
reviewed
Feb 4, 2025
mosabua
requested changes
Feb 4, 2025
nineinchnick
force-pushed
the
faker-ctas-docs
branch
from
9c9a921 to
4d5b553
Compare
mosabua
force-pushed
the
faker-ctas-docs
branch
from
4d5b553 to
126eb4d
Compare
mosabua
force-pushed
the
faker-ctas-docs
branch
from
126eb4d to
85d6987
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #24585. I ran the Vale linter and it spotted usages of
will, so I also fixed that in the config and schema/table/column property descriptions.Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: