-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for reading variant type in Delta Lake #22403
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edd694e
to
780c769
Compare
d891034
to
a553eb8
Compare
a553eb8
to
46ad916
Compare
46ad916
to
82ff5b2
Compare
Hey, are there any plans to finish this feature as it would be highly useful? |
82ff5b2
to
880cf40
Compare
880cf40
to
71ca4f2
Compare
71ca4f2
to
957aa80
Compare
wendigo
reviewed
Feb 6, 2025
lib/trino-parquet/src/main/java/io/trino/parquet/ParquetTypeUtils.java
Outdated
Show resolved
Hide resolved
wendigo
reviewed
Feb 6, 2025
lib/trino-parquet/src/main/java/io/trino/parquet/ParquetTypeUtils.java
Outdated
Show resolved
Hide resolved
wendigo
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't review copied/reformatted classes
957aa80
to
8752700
Compare
8752700
to
2e558df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla-signed
delta-lake
Delta Lake connector
hive
Hive connector
stale-ignore
Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The relevant classes can be moved to toolkit module or engine when we use it from Iceberg connector.
We should consider adding a new type
variant
instead of reusingjson
type.I reused
json
type in this PR because old clients (e.g. CLI) can't print human-readable values for new types and I expect JSON functions will be used on the column.Fixes #22309
Release notes