Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for reading variant type in Delta Lake #22403

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Jun 17, 2024

Description

The relevant classes can be moved to toolkit module or engine when we use it from Iceberg connector.

We should consider adding a new type variant instead of reusing json type.
I reused json type in this PR because old clients (e.g. CLI) can't print human-readable values for new types and I expect JSON functions will be used on the column.

Fixes #22309

Release notes

# Delta Lake
* Add support for reading `variant` type. ({issue}`22309`)

@cla-bot cla-bot bot added the cla-signed label Jun 17, 2024
@github-actions github-actions bot added delta-lake Delta Lake connector hive Hive connector labels Jun 17, 2024
@ebyhr ebyhr force-pushed the ebi/delta-variant branch 3 times, most recently from edd694e to 780c769 Compare June 19, 2024 22:47
@ebyhr ebyhr force-pushed the ebi/delta-variant branch from 780c769 to b7b53e0 Compare July 5, 2024 02:56
@ebyhr ebyhr force-pushed the ebi/delta-variant branch 2 times, most recently from d891034 to a553eb8 Compare July 26, 2024 01:54
@ebyhr ebyhr force-pushed the ebi/delta-variant branch from a553eb8 to 46ad916 Compare August 14, 2024 11:35
@ebyhr ebyhr force-pushed the ebi/delta-variant branch from 46ad916 to 82ff5b2 Compare October 7, 2024 08:10
@benbauer-draeger
Copy link

Hey, are there any plans to finish this feature as it would be highly useful?

@ebyhr ebyhr force-pushed the ebi/delta-variant branch from 82ff5b2 to 880cf40 Compare November 27, 2024 14:19
@ebyhr ebyhr marked this pull request as ready for review November 29, 2024 06:37
@github-actions github-actions bot added the stale label Dec 20, 2024
@trinodb trinodb deleted a comment from github-actions bot Dec 20, 2024
@ebyhr ebyhr force-pushed the ebi/delta-variant branch from 880cf40 to 71ca4f2 Compare December 20, 2024 22:36
@github-actions github-actions bot removed the stale label Dec 23, 2024
@github-actions github-actions bot added the stale label Jan 13, 2025
@ebyhr ebyhr added stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed. and removed stale labels Jan 19, 2025
@ebyhr ebyhr marked this pull request as draft January 20, 2025 23:38
@trinodb trinodb deleted a comment from github-actions bot Jan 23, 2025
@ebyhr ebyhr marked this pull request as ready for review January 24, 2025 01:07
@ebyhr ebyhr force-pushed the ebi/delta-variant branch from 71ca4f2 to 957aa80 Compare January 31, 2025 06:31
Copy link
Contributor

@wendigo wendigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't review copied/reformatted classes

@ebyhr ebyhr force-pushed the ebi/delta-variant branch from 957aa80 to 8752700 Compare February 6, 2025 09:49
@ebyhr ebyhr force-pushed the ebi/delta-variant branch from 8752700 to 2e558df Compare February 6, 2025 09:55
@ebyhr ebyhr merged commit a594bea into trinodb:master Feb 6, 2025
60 of 61 checks passed
@ebyhr ebyhr deleted the ebi/delta-variant branch February 6, 2025 12:33
@github-actions github-actions bot added this to the 471 milestone Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed delta-lake Delta Lake connector hive Hive connector stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed.
Development

Successfully merging this pull request may close these issues.

Add support for reading variant type in Delta Lake connector
3 participants