Add pull request template #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@colebow PTAL as well. |
hashhar
approved these changes
Sep 12, 2022
mosabua
reviewed
Sep 13, 2022
.github/pull_request_template.md
Outdated
| ( ) Release notes are required, with the following suggested text: | ||
|
|
||
| ```markdown | ||
| # Section |
There was a problem hiding this comment.
This might not be needed in the python client since the release notes are probably just one list of items without sections/headers.
There was a problem hiding this comment.
SQLAlchemy, DB-API, General improvements? But yes - it feels overkill for now. We can add it back if needed.
There was a problem hiding this comment.
Should I remove a whole markdown section then?
There was a problem hiding this comment.
I think Manfred just means the # Section header. The markdown template is useful to have.
|
Should we also institute the same process of getting release notes assembled .. maybe even separate file .. or easier.. just an update to the changelog file that was proposed in #221 |
hovaesco
force-pushed
the
hovaesco/pr-template
branch
from
1e48201 to
8daa427
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost 1:1 copy from Trino repository. It will help maintain release notes in the same way as in Trino project.