Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

Library refactoring #328

Closed
15 tasks done
trimox opened this issue Oct 29, 2017 · 1 comment · Fixed by #329
Closed
15 tasks done

Library refactoring #328

trimox opened this issue Oct 29, 2017 · 1 comment · Fixed by #329
Assignees
@trimox
Labels
enhancement techdebt
Milestone
Milestone v0.5.6

Comments

@trimox
Copy link
Owner

trimox commented Oct 29, 2017 •
edited
Loading

  • Rename _root to elementRef
  • Make directive and component ElementRef public accessible
  • Remove directive and component from src/lib file names
  • Make event registry listen and unlisten public accessible
  • Add passive event handling to event registry
  • Prefix private variables with leading underscore
  • Functions must specify strongly-typed object(s)
  • Add pointerup + mouseup types to ripple's Interaction Handler. reference: Button with ripples stays focused after mouse is moved away material-components/material-components-web#1124 (comment)
  • Set default property values
  • Rename MDC adapter files to adapter.d.ts
  • Refactor MdcFormField
  • Prefix events with on instead of handle (e.g.: onKeyPress)
  • Set encapsulation to ViewEncapsulation.None
  • Refactor mdc-icon-toggle to use mdc-icon
  • Change MdcList to Directive
@trimox trimox added this to the Milestone v0.5.6 milestone Oct 29, 2017
@trimox trimox self-assigned this Oct 29, 2017
@trimox
Copy link
Owner Author

trimox commented Oct 30, 2017

Updating unit tests.

trimox added a commit that referenced this issue Oct 30, 2017
@trimox
refactor: Library improvements + refactoring
27354e0 
Closes #328
@trimox trimox mentioned this issue Oct 30, 2017
Merged
15 tasks
trimox added a commit that referenced this issue Oct 30, 2017
@trimox
refactor: Library improvements + refactoring (#329)
d7f516c 
Closes #328
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@trimox trimox

Labels
enhancement techdebt
Projects
None yet
Milestone
Milestone v0.5.6
Development

Successfully merging a pull request may close this issue.

refactor: Library improvements + refactoring trimox/angular-mdc-web
1 participant
@trimox