Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MueLu: Adding support for driving Galeri options via ParameterList in Driver #9871

Merged
merged 3 commits into from
Oct 28, 2021
Merged

MueLu: Adding support for driving Galeri options via ParameterList in Driver #9871

merged 3 commits into from
Oct 28, 2021

Conversation

csiefer2
Copy link
Member

@csiefer2 csiefer2 commented Oct 27, 2021 •
edited
Loading

TESTS: Added
Issue: n/a (non-ASC)
Stakeholder feedback: n/a (non-ASC)

@csiefer2 csiefer2 requested a review from a team as a code owner October 27, 2021 22:17
@csiefer2 csiefer2 added the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Oct 27, 2021
@csiefer2 csiefer2 requested review from jhux2 and rstumin October 27, 2021 22:17
GrahamBenHarper
GrahamBenHarper requested changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@GrahamBenHarper GrahamBenHarper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this missing the .xml?

GrahamBenHarper
GrahamBenHarper approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@GrahamBenHarper GrahamBenHarper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better :)

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 5878
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE
PULLREQUESTNUM 9871
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH csiefer-c47b1dc
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA e442df7
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0e6ccca

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_serial

  • Build Num: 3423
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE
PULLREQUESTNUM 9871
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH csiefer-c47b1dc
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA e442df7
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0e6ccca

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_debug

  • Build Num: 3941
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE
PULLREQUESTNUM 9871
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH csiefer-c47b1dc
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA e442df7
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0e6ccca

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 11111
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE
PULLREQUESTNUM 9871
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH csiefer-c47b1dc
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA e442df7
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0e6ccca

Build Information

Test Name: Trilinos_pullrequest_cuda_10.1.105

  • Build Num: 2580
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE
PULLREQUESTNUM 9871
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH csiefer-c47b1dc
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA e442df7
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0e6ccca

Build Information

Test Name: Trilinos_pullrequest_cuda_10.1.105_uvm_off

  • Build Num: 1571
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE
PULLREQUESTNUM 9871
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH csiefer-c47b1dc
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA e442df7
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0e6ccca

Build Information

Test Name: Trilinos_pullrequest_clang_10.0.0

  • Build Num: 3909
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE
PULLREQUESTNUM 9871
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH csiefer-c47b1dc
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA e442df7
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0e6ccca

Build Information

Test Name: python-3

  • Build Num: 545
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE
PULLREQUESTNUM 9871
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH csiefer-c47b1dc
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA e442df7
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0e6ccca

Using Repos:

Repo: TRILINOS (trilinos/Trilinos)
  • Branch: csiefer-c47b1dc
  • SHA: e442df7
  • Mode: TEST_REPO

Pull Request Author: csiefer2

jhux2
jhux2 reviewed Oct 27, 2021
View reviewed changes
packages/muelu/test/scaling/Driver.cpp
// Galeri updates (only works with Run1)
if(paramList.sublist("Run1").isSublist("Galeri")) {
ParameterList& moreParams = paramList.sublist("Run1").sublist("Galeri");
std::cout<<"*** moreParams ***"<<std::endl<<moreParams<<std::endl;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider changing std::cout to out to avoid all processes printing.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 5878
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE
PULLREQUESTNUM 9871
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH csiefer-c47b1dc
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA e442df7
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0e6ccca

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_serial

  • Build Num: 3423
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE
PULLREQUESTNUM 9871
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH csiefer-c47b1dc
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA e442df7
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0e6ccca

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_debug

  • Build Num: 3941
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE
PULLREQUESTNUM 9871
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH csiefer-c47b1dc
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA e442df7
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0e6ccca

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 11111
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE
PULLREQUESTNUM 9871
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH csiefer-c47b1dc
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA e442df7
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0e6ccca

Build Information

Test Name: Trilinos_pullrequest_cuda_10.1.105

  • Build Num: 2580
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE
PULLREQUESTNUM 9871
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH csiefer-c47b1dc
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA e442df7
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0e6ccca

Build Information

Test Name: Trilinos_pullrequest_cuda_10.1.105_uvm_off

  • Build Num: 1571
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE
PULLREQUESTNUM 9871
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH csiefer-c47b1dc
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA e442df7
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0e6ccca

Build Information

Test Name: Trilinos_pullrequest_clang_10.0.0

  • Build Num: 3909
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE
PULLREQUESTNUM 9871
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH csiefer-c47b1dc
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA e442df7
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0e6ccca

Build Information

Test Name: python-3

  • Build Num: 545
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE
PULLREQUESTNUM 9871
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH csiefer-c47b1dc
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA e442df7
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0e6ccca


CDash Test Results for PR# 9871.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ GrahamBenHarper ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester trilinos-autotester merged commit 9ef3d88 into develop Oct 28, 2021
@trilinos-autotester
Copy link
Contributor

Merge on Pull Request# 9871: IS A SUCCESS - Pull Request successfully merged

@trilinos-autotester trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Oct 28, 2021
@csiefer2 csiefer2 deleted the csiefer-c47b1dc branch October 28, 2021 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgcgcg cgcgcg cgcgcg left review comments

@jhux2 jhux2 jhux2 left review comments

@GrahamBenHarper GrahamBenHarper GrahamBenHarper approved these changes

@rstumin rstumin Awaiting requested review from rstumin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@csiefer2 @trilinos-autotester @cgcgcg @GrahamBenHarper @jhux2