Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PanzerAdaptersSTK_STK_ResponseLibraryTest2_MPI_2 with UVM off #9652

Merged
merged 2 commits into from
Sep 3, 2021
Merged

Fix PanzerAdaptersSTK_STK_ResponseLibraryTest2_MPI_2 with UVM off #9652

merged 2 commits into from
Sep 3, 2021

Conversation

JacobDomagala
Copy link
Contributor

No description provided.

@JacobDomagala JacobDomagala requested a review from a team as a code owner September 2, 2021 15:39
bathmatt
bathmatt reviewed Sep 2, 2021
View reviewed changes
packages/panzer/disc-fe/src/responses/Panzer_ResponseScatterEvaluator_Functional.hpp
LIDs = ugis_[b]->getElementLIDs(cellLocalId);
LIDs = ugis_[b]->getElementLIDs(cellLocalId);
auto LIDs_h = Kokkos::create_mirror_view(LIDs);
Kokkos::deep_copy(LIDs_h, LIDs);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use the same trick you did in the blocked epetra and move the LIDs_h outside the worksetCellIndex loop? This will replace 1000s of deep copies with just 1 at the start

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
THE LAST COMMIT TO THIS PULL REQUEST HAS BEEN REVIEWED, BUT NOT ACCEPTED OR REQUIRES CHANGES

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
THE LAST COMMIT TO THIS PULL REQUEST HAS NOT BEEN REVIEWED YET!

@bathmatt bathmatt added AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed pkg: Panzer UVM removal labels Sep 3, 2021
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ bathmatt ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 5473
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Panzer;AT: AUTOMERGE;UVM removal
PULLREQUESTNUM 9652
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH JD_Panzer_UVM_Off
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA fce9580
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 65fc34e

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_serial

  • Build Num: 3030
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Panzer;AT: AUTOMERGE;UVM removal
PULLREQUESTNUM 9652
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH JD_Panzer_UVM_Off
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA fce9580
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 65fc34e

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_debug

  • Build Num: 3510
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Panzer;AT: AUTOMERGE;UVM removal
PULLREQUESTNUM 9652
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH JD_Panzer_UVM_Off
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA fce9580
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 65fc34e

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 10753
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Panzer;AT: AUTOMERGE;UVM removal
PULLREQUESTNUM 9652
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH JD_Panzer_UVM_Off
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA fce9580
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 65fc34e

Build Information

Test Name: Trilinos_pullrequest_cuda_10.1.105

  • Build Num: 2164
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Panzer;AT: AUTOMERGE;UVM removal
PULLREQUESTNUM 9652
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH JD_Panzer_UVM_Off
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA fce9580
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 65fc34e

Build Information

Test Name: Trilinos_pullrequest_cuda_10.1.105_uvm_off

  • Build Num: 1161
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Panzer;AT: AUTOMERGE;UVM removal
PULLREQUESTNUM 9652
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH JD_Panzer_UVM_Off
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA fce9580
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 65fc34e

Build Information

Test Name: Trilinos_pullrequest_clang_10.0.0

  • Build Num: 3541
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Panzer;AT: AUTOMERGE;UVM removal
PULLREQUESTNUM 9652
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH JD_Panzer_UVM_Off
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA fce9580
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 65fc34e

Build Information

Test Name: python-3

  • Build Num: 195
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Panzer;AT: AUTOMERGE;UVM removal
PULLREQUESTNUM 9652
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH JD_Panzer_UVM_Off
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA fce9580
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 65fc34e

Using Repos:

Repo: TRILINOS (NexGenAnalytics/Trilinos)
  • Branch: JD_Panzer_UVM_Off
  • SHA: fce9580
  • Mode: TEST_REPO

Pull Request Author: JacobDomagala

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 5473
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Panzer;AT: AUTOMERGE;UVM removal
PULLREQUESTNUM 9652
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH JD_Panzer_UVM_Off
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA fce9580
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 65fc34e

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_serial

  • Build Num: 3030
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Panzer;AT: AUTOMERGE;UVM removal
PULLREQUESTNUM 9652
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH JD_Panzer_UVM_Off
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA fce9580
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 65fc34e

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_debug

  • Build Num: 3510
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Panzer;AT: AUTOMERGE;UVM removal
PULLREQUESTNUM 9652
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH JD_Panzer_UVM_Off
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA fce9580
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 65fc34e

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 10753
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Panzer;AT: AUTOMERGE;UVM removal
PULLREQUESTNUM 9652
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH JD_Panzer_UVM_Off
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA fce9580
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 65fc34e

Build Information

Test Name: Trilinos_pullrequest_cuda_10.1.105

  • Build Num: 2164
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Panzer;AT: AUTOMERGE;UVM removal
PULLREQUESTNUM 9652
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH JD_Panzer_UVM_Off
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA fce9580
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 65fc34e

Build Information

Test Name: Trilinos_pullrequest_cuda_10.1.105_uvm_off

  • Build Num: 1161
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Panzer;AT: AUTOMERGE;UVM removal
PULLREQUESTNUM 9652
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH JD_Panzer_UVM_Off
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA fce9580
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 65fc34e

Build Information

Test Name: Trilinos_pullrequest_clang_10.0.0

  • Build Num: 3541
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Panzer;AT: AUTOMERGE;UVM removal
PULLREQUESTNUM 9652
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH JD_Panzer_UVM_Off
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA fce9580
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 65fc34e

Build Information

Test Name: python-3

  • Build Num: 195
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Panzer;AT: AUTOMERGE;UVM removal
PULLREQUESTNUM 9652
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH JD_Panzer_UVM_Off
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA fce9580
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 65fc34e


CDash Test Results for PR# 9652.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ bathmatt ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester trilinos-autotester merged commit 862f9d6 into trilinos:develop Sep 3, 2021
@trilinos-autotester
Copy link
Contributor

Merge on Pull Request# 9652: IS A SUCCESS - Pull Request successfully merged

@trilinos-autotester trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bathmatt bathmatt bathmatt approved these changes

Assignees
No one assigned
Labels
pkg: Panzer UVM removal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JacobDomagala @trilinos-autotester @bathmatt