Intrepid2: fix shadowed DeviceType declarations in function scope #9651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
CamelliaDPG
approved these changes
Sep 2, 2021
|
Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ CamelliaDPG ]! |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0_serial
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0_debug
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_10.1.105
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_10.1.105_uvm_off
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_10.0.0
Jenkins Parameters
Build InformationTest Name: python-3
Jenkins Parameters
Using Repos:
Pull Request Author: japlews |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0_serial
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0_debug
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_10.1.105
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_10.1.105_uvm_off
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_10.0.0
Jenkins Parameters
Build InformationTest Name: python-3
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ CamelliaDPG ]! |
|
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
5 similar comments
|
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
|
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
|
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
|
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
|
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
jmgate
pushed a commit
to tcad-charon/Trilinos
that referenced
this pull request
Sep 9, 2021
…s:develop' (28932b4). * trilinos-develop: Fixed up model evaluator test, tanget scatters Intrepid2: fix shadowed DeviceType declarations in function scope (trilinos#9651) MueLu: Clean up SemiCoarsenP factories Panzer: fix response evaluation for uvm removal Add SemiCoarsenPFactory unit test - this test uses the SemiCoarsenP matrix to prolongate the coarse grid coordinates into fine grid coordinates. It only works on the third layer of a 5 layer grid because of boundary conditions. - also SemiCoarsenPFactory_kokkos fixes for complex types MueLu: Add SemiCoarsenPFactory_kokkos - kokkos version of SemiCoarsenPFactory
jmgate
pushed a commit
to tcad-charon/Trilinos
that referenced
this pull request
Sep 9, 2021
…s:develop' (28932b4). * trilinos-develop: Fixed up model evaluator test, tanget scatters Intrepid2: fix shadowed DeviceType declarations in function scope (trilinos#9651) MueLu: Clean up SemiCoarsenP factories Panzer: fix response evaluation for uvm removal Add SemiCoarsenPFactory unit test - this test uses the SemiCoarsenP matrix to prolongate the coarse grid coordinates into fine grid coordinates. It only works on the third layer of a 5 layer grid because of boundary conditions. - also SemiCoarsenPFactory_kokkos fixes for complex types MueLu: Add SemiCoarsenPFactory_kokkos - kokkos version of SemiCoarsenPFactory
PhilMiller
pushed a commit
to PhilMiller/Trilinos
that referenced
this pull request
Dec 22, 2021
…develop' (d5609d7). * trilinos/develop: (23 commits) Fixed up model evaluator test, tanget scatters Intrepid2: fix shadowed DeviceType declarations in function scope (trilinos#9651) MueLu: Clean up SemiCoarsenP factories Panzer: fix response evaluation for uvm removal Tpetra: added methods to replace Domain and Range maps in CrsMatrix and CrsGraph (trilinos#9626) Fixed uvm error with building the sideset coords Fixed Dirichlet resid for edge basis and UVM Resolved UVM issues Minor fixes in some of the source terms for examples reset view ref to equalize count another device access Have simple tpetra example working have some memory access errors resolved tpetra: reduced amount of output to reduce test failures due to intermixed output more progress more progress fixed centroid code Fixed inv perm func have epetra stack going partially through Fixed up some view of view errors ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trilinos/Intrepid2
@mperego @kyungjoo-kim
Motivation
Shadowed declaration of
DeviceTypein class scope; there are several other declarations in function scope which seem to be no longer needed.Stakeholder Feedback
N/A
Testing
N/A