Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tempus: Additional Cleanup of Squareroot. #7475

Merged
merged 1 commit into from
Jun 5, 2020
Merged

Tempus: Additional Cleanup of Squareroot. #7475

merged 1 commit into from
Jun 5, 2020

Conversation

ccober6
Copy link
Contributor

@ccober6 ccober6 commented Jun 3, 2020

Found some additional poor uses of Teuchos::ScalarTraits::squareroot.

All tests pass.

@trilinos/tempus

Closes #4176

@ccober6
Tempus: Additional Cleanup of Squareroot.
a7e9915 
Found some additional poor uses of Teuchos::ScalarTraits::squareroot.

All tests pass.
@ccober6 ccober6 added type: bug The primary issue is a bug in Trilinos code or tests pkg: Tempus client: EMPIRE All issues that most directly target the ATDM EMPIRE code labels Jun 3, 2020
@ccober6 ccober6 requested a review from sconde June 3, 2020 20:15
@ccober6 ccober6 self-assigned this Jun 3, 2020
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 6899
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 7475
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 4176-Tempus-NaNs-thrown-from-sqrt-with-Clang-debug-builds
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA a7e9915
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 184c490

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 6710
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7475
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 4176-Tempus-NaNs-thrown-from-sqrt-with-Clang-debug-builds
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA a7e9915
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 184c490

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 5135
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7475
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 4176-Tempus-NaNs-thrown-from-sqrt-with-Clang-debug-builds
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA a7e9915
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 184c490

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 4982
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7475
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 4176-Tempus-NaNs-thrown-from-sqrt-with-Clang-debug-builds
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA a7e9915
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 184c490

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 1171
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7475
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 4176-Tempus-NaNs-thrown-from-sqrt-with-Clang-debug-builds
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA a7e9915
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 184c490

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 4467
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7475
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 4176-Tempus-NaNs-thrown-from-sqrt-with-Clang-debug-builds
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA a7e9915
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 184c490

Build Information

Test Name: Trilinos_pullrequest_clang_9.0.0

  • Build Num: 842
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7475
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 4176-Tempus-NaNs-thrown-from-sqrt-with-Clang-debug-builds
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA a7e9915
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 184c490

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 2590
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7475
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 4176-Tempus-NaNs-thrown-from-sqrt-with-Clang-debug-builds
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA a7e9915
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 184c490

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 2601
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7475
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 4176-Tempus-NaNs-thrown-from-sqrt-with-Clang-debug-builds
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA a7e9915
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 184c490

Using Repos:

Repo: TRILINOS (trilinos/Trilinos)
  • Branch: 4176-Tempus-NaNs-thrown-from-sqrt-with-Clang-debug-builds
  • SHA: a7e9915
  • Mode: TEST_REPO

Pull Request Author: ccober6

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 6899
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 7475
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 4176-Tempus-NaNs-thrown-from-sqrt-with-Clang-debug-builds
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA a7e9915
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 184c490

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 6710
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7475
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 4176-Tempus-NaNs-thrown-from-sqrt-with-Clang-debug-builds
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA a7e9915
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 184c490

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 5135
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7475
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 4176-Tempus-NaNs-thrown-from-sqrt-with-Clang-debug-builds
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA a7e9915
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 184c490

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 4982
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7475
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 4176-Tempus-NaNs-thrown-from-sqrt-with-Clang-debug-builds
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA a7e9915
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 184c490

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 1171
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7475
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 4176-Tempus-NaNs-thrown-from-sqrt-with-Clang-debug-builds
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA a7e9915
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 184c490

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 4467
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7475
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 4176-Tempus-NaNs-thrown-from-sqrt-with-Clang-debug-builds
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA a7e9915
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 184c490

Build Information

Test Name: Trilinos_pullrequest_clang_9.0.0

  • Build Num: 842
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7475
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 4176-Tempus-NaNs-thrown-from-sqrt-with-Clang-debug-builds
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA a7e9915
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 184c490

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 2590
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7475
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 4176-Tempus-NaNs-thrown-from-sqrt-with-Clang-debug-builds
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA a7e9915
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 184c490

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 2601
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7475
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 4176-Tempus-NaNs-thrown-from-sqrt-with-Clang-debug-builds
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA a7e9915
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 184c490


CDash Test Results for PR# 7475.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

1 similar comment
@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sconde
sconde approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@sconde sconde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ sconde ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR...

@ccober6 ccober6 merged commit 7406422 into develop Jun 5, 2020
@ccober6 ccober6 deleted the 4176-Tempus-NaNs-thrown-from-sqrt-with-Clang-debug-builds branch June 5, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sconde sconde sconde approved these changes

Assignees

@ccober6 ccober6

Labels
client: EMPIRE All issues that most directly target the ATDM EMPIRE code pkg: Tempus type: bug The primary issue is a bug in Trilinos code or tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ccober6 @trilinos-autotester @sconde