Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ATDM/ats2: Disable hack around error message #7406

Merged
merged 1 commit into from
May 28, 2020
Merged

ATDM/ats2: Disable hack around error message #7406

merged 1 commit into from
May 28, 2020

Conversation

e10harvey
Copy link
Contributor

This retry logic did not generated unique .out file names since some "Command Lines" are exactly the same but post to different ctest "Test" names. To make the retry logic work, we need the ctest "Test" name in the environment in order to generate a uniqe .out file name. This change disables the retry logic and may result in the mass Errors we were trying to work around. The retry code has been commented out but left there in case we need it again in the future.

How was this tested?

See atdv-351.

@e10harvey e10harvey added the type: bug The primary issue is a bug in Trilinos code or tests label May 21, 2020
@e10harvey e10harvey requested a review from bartlettroscoe May 21, 2020 15:19
@e10harvey e10harvey self-assigned this May 21, 2020
@bartlettroscoe bartlettroscoe added ATDM Config Issues that are specific to the ATDM configuration settings ATDM DevOps Issues that will be worked by the Coordinated ATDM DevOps teams client: ATDM Any issue primarily impacting the ATDM project labels May 21, 2020
@bartlettroscoe
Copy link
Member

@e10harvey, I think we will need to do some pretty significant offline testing before we merge a PR lke this because it is possible it could cause mass test failures. But I have seen strange random errors in some of the tests that might be explained by the temp *.out file not being unique so it will be good to test this out and get it merged. At the same time, I would also like to consider adding logic to highlight the exit code 255 failures outlined in #7122. (For those changes, I will create a PR against this PR branch for you to review).

Thanks again!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@bartlettroscoe bartlettroscoe mentioned this pull request May 21, 2020
Open
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 6767
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 7406
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH swat_trilinos_jsrun_bug
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA 485013e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d9bd396

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 6579
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7406
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH swat_trilinos_jsrun_bug
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA 485013e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d9bd396

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 5004
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7406
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH swat_trilinos_jsrun_bug
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA 485013e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d9bd396

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 4851
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7406
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH swat_trilinos_jsrun_bug
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA 485013e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d9bd396

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 1041
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7406
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH swat_trilinos_jsrun_bug
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA 485013e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d9bd396

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 4341
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7406
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH swat_trilinos_jsrun_bug
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA 485013e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d9bd396

Build Information

Test Name: Trilinos_pullrequest_clang_9.0.0

  • Build Num: 716
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7406
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH swat_trilinos_jsrun_bug
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA 485013e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d9bd396

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 2479
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7406
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH swat_trilinos_jsrun_bug
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA 485013e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d9bd396

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 2490
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7406
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH swat_trilinos_jsrun_bug
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA 485013e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d9bd396

Using Repos:

Repo: TRILINOS (e10harvey/Trilinos)
  • Branch: swat_trilinos_jsrun_bug
  • SHA: 485013e
  • Mode: TEST_REPO

Pull Request Author: e10harvey

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 6767
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 7406
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH swat_trilinos_jsrun_bug
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA 485013e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d9bd396

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 6579
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7406
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH swat_trilinos_jsrun_bug
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA 485013e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d9bd396

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 5004
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7406
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH swat_trilinos_jsrun_bug
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA 485013e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d9bd396

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 4851
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7406
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH swat_trilinos_jsrun_bug
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA 485013e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d9bd396

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 1041
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7406
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH swat_trilinos_jsrun_bug
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA 485013e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d9bd396

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 4341
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7406
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH swat_trilinos_jsrun_bug
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA 485013e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d9bd396

Build Information

Test Name: Trilinos_pullrequest_clang_9.0.0

  • Build Num: 716
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7406
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH swat_trilinos_jsrun_bug
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA 485013e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d9bd396

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 2479
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7406
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH swat_trilinos_jsrun_bug
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA 485013e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d9bd396

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 2490
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7406
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH swat_trilinos_jsrun_bug
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA 485013e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d9bd396


CDash Test Results for PR# 7406.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

1 similar comment
@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

2 similar comments
@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@bartlettroscoe bartlettroscoe mentioned this pull request May 26, 2020
Merged
@bartlettroscoe
Copy link
Member

FYI: Will be merged as part of larger PR #7427.

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

bartlettroscoe
bartlettroscoe approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@bartlettroscoe bartlettroscoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged this in and tested this as part of #7427 and it seemed to work great. It looks like we don't need to bother with temp *.out files anymore and we don't need retries. (But we still see mass random failures that occur as described in #6861 but I think that is unrelated.)

We don't need to merge this PR. GitHub will show it merged automatically when PR #7427 gets merged to 'develop'.

. When PR #7427 gets merged, GitHub will automatically show this PR as being merged.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ bartlettroscoe ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR...

@trilinos-autotester trilinos-autotester added the AT: STALE Added by the PR autotester if too much time has elapsed since the last successful PR test iteration label May 27, 2020
@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

trilinos-autotester added a commit that referenced this pull request May 28, 2020
@trilinos-autotester
Merge Pull Request #7427 from bartlettroscoe/Trilinos/atdv-351-atdm-a…
d1803f8 
…ts2-refactor

Automatically Merged using Trilinos Pull Request AutoTester
PR Title: ATDM: Address several 'ats2' issues (#7402, #7406, #7122, #2422)
PR Author: bartlettroscoe
@trilinos-autotester trilinos-autotester merged commit 9eb7010 into trilinos:develop May 28, 2020
@bartlettroscoe
Copy link
Member

@e10harvey, see, GitHub automatically shows this PR as merged once PR #7427 was merged!

@bartlettroscoe
Copy link
Member

And look the label AT: STALE is still applied, even through the PR got merged. This seems like hole in the autotester use cases. This is kind of confusing to anyone looking at these GitHub merged PRs.

@e10harvey e10harvey deleted the swat_trilinos_jsrun_bug branch July 23, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlettroscoe bartlettroscoe bartlettroscoe approved these changes

Assignees

@e10harvey e10harvey

Labels
AT: STALE Added by the PR autotester if too much time has elapsed since the last successful PR test iteration ATDM Config Issues that are specific to the ATDM configuration settings ATDM DevOps Issues that will be worked by the Coordinated ATDM DevOps teams client: ATDM Any issue primarily impacting the ATDM project type: bug The primary issue is a bug in Trilinos code or tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@e10harvey @bartlettroscoe @trilinos-autotester