-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set TEST_0 PASS_REGULAR_EXPRESSION and untangle test-block and overall args #7229
Set TEST_0 PASS_REGULAR_EXPRESSION and untangle test-block and overall args #7229
Conversation
…l args I noticed this while looking over this failing test on CDash. I should update the TriBITS documentation to advise people not to set FINAL_PASS_REGULAR_EXPRESSION but instead determine pass/fail at the TEST_<idx> block level.
I tried to set reviewers who modified this package recently but there are are not many recent commits as shown by:
|
@bartlettroscoe changes look good to me, I'm adding @ambrad to see if he can give an okay as well |
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_9.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
Using Repos:
Pull Request Author: bartlettroscoe |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_9.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
@trilinos/shylu WARNING: PR testing did not actually run this test!!!! See CDash results. @trilinos/framework, how is that possible? The configure output shown here at the top shows:
I can't see where that logic is being performed but this needs to be fixed ASAP! |
FYI: This not getting tested looks to be related to #6697 and some bug with testing Primary Tested vs Secondary Tested code. |
Let me fix #6697 so that this gets tested and then we can merge? |
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ ambrad ]! |
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
5 similar comments
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest.... |
2 similar comments
All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest.... |
All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest.... |
FYI: Once PR #7414 merges to 'develop', then we can run another PR test iteration for this PR and ShyLU_NodeHTS and other ST packages will get tested in PR testing. |
All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest.... |
1 similar comment
All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest.... |
…6697, trilinos#7229) I added an explict test for the subpackage ShyLU_NodeHTS to make sure it will get tested if there are any changes (see trilinos#7229). I also changed the list of toplevel packages as CDash subproject to list all of the PR packages. This is because you can't just list the changed SE packages, you have to list all of the top-level packages that have any enabled subpackages downstream. That type of logic will require doing a full TriBITS dependency analysis in CMake code calling the macro TRIBITS_ADJUST_AND_PRINT_PACKAGE_DEPENDENCIES(). That will require some refactoring that I don't have the time to do now. But note that at least the list of toplevel packages will always be correct as there are changes to the Trilinos/PackagesList.cmake file. That is better than using a static list that never gets updated.
All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest.... |
All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest.... |
Now that PR #7414 just merged, we can retest this PR and the PR tester should actually test ShyLU_NodeHTS. |
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_9.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
Using Repos:
Pull Request Author: bartlettroscoe |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_9.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
|
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
FYI: Note that, as predicted, the last PR testing iteration shown here (sort by "Start Time") we see that indeed the
and we see packages with 1 or more tests here showing:
Excellent! I will now merge this. |
…s:develop' (84480d7). * trilinos-develop: (28 commits) This simply unlinks the 'package_subproject_list.cmake' temporary created during testing Add test for ShyLU_NodeHTS and list all packages for CDash (trilinos#6697, trilinos#7229) Add running of get-changed-trilinos-packages-helpers-unit-tests.sh (trilinos#6697) Fix a space error in Python-only builds CTEST_LABELS_FOR_SUBPROJECTS var (trilinos#6697) Fix tests for addition of package_subproject_list.cmake file (trilinos#6697) Exclude some ST packages from PR testing selection (trilinos#6697) Move shunit2 to be reused in TrilinosFrameworkTests (trilinos#6697) Write a package_subproject_list.cmake file for Python-only builds (trilinos#6697) MueLu RefMaxwell: Apply BCs to A_nodal Intrepid2: Changes to Projection Tools - made dependency on KokkosKernels optional - improved solution of element projections by re-using matrix factorization when possible MueLu Utilities: Add Kokkos version of ApplyOAZToMatrixRows Update Tpetra_Details_Behavior.hpp Use generated package_subproject_list.cmake file (trilinos#3272) Add support for generating CTEST_LABELS_FOR_SUBPROJECTS (trilinos#6697) Automatic snapshot commit from tribits at 52acd38 Return all PT and ST changed packages (trilinos#6697) added a couple of large mv tests adds details support for long multivector thresholds tpetra: Include multivector length in deciding where kernels should run. Intrepid2: Modified tests to exercise projection of Hierarchical basis ...
…s:develop' (84480d7). * trilinos-develop: (28 commits) This simply unlinks the 'package_subproject_list.cmake' temporary created during testing Add test for ShyLU_NodeHTS and list all packages for CDash (trilinos#6697, trilinos#7229) Add running of get-changed-trilinos-packages-helpers-unit-tests.sh (trilinos#6697) Fix a space error in Python-only builds CTEST_LABELS_FOR_SUBPROJECTS var (trilinos#6697) Fix tests for addition of package_subproject_list.cmake file (trilinos#6697) Exclude some ST packages from PR testing selection (trilinos#6697) Move shunit2 to be reused in TrilinosFrameworkTests (trilinos#6697) Write a package_subproject_list.cmake file for Python-only builds (trilinos#6697) MueLu RefMaxwell: Apply BCs to A_nodal Intrepid2: Changes to Projection Tools - made dependency on KokkosKernels optional - improved solution of element projections by re-using matrix factorization when possible MueLu Utilities: Add Kokkos version of ApplyOAZToMatrixRows Update Tpetra_Details_Behavior.hpp Use generated package_subproject_list.cmake file (trilinos#3272) Add support for generating CTEST_LABELS_FOR_SUBPROJECTS (trilinos#6697) Automatic snapshot commit from tribits at 52acd38 Return all PT and ST changed packages (trilinos#6697) added a couple of large mv tests adds details support for long multivector thresholds tpetra: Include multivector length in deciding where kernels should run. Intrepid2: Modified tests to exercise projection of Hierarchical basis ...
I noticed this while looking over this failing test on CDash like here.
I should update the TriBITS documentation to advise people not to set FINAL_PASS_REGULAR_EXPRESSION but instead determine pass/fail at the
TEST_<idx>
block level.How was this tested?
I configured, built, and ran this single ShyLU_NodeHTS locally and it showed:
Note the criteria:
NOTE, you might also want to use the
ALWAYS_FAIL_ON_NONZERO_RETURN
option as well documented at: