Testing: Tpetra: enable downstream testing with deprecrated code disabled #5789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test downstream packages with Tpetra deprecated code disabled
Dial back the build parallelism in the Tpetra downstream testing to avoid some weird build failures in ROL. (Thanks to Tim Fuller for the tip!), and add some explicit package disables. In order to do this, I moved the build parallelism to the individual tests, rather than the base file TrilinosCTestDriverCore.rocketman.gcc.cmake. I couldn't figure out how to override the parallelism for a particular test. Addresses #5787.
jhux2
added
AT: AUTOMERGE
jhux2
requested review from
csiefer2,
tjfulle,
GeoffDanielson,
mhoemmen,
kddevin and
brian-kelley
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
Using Repos:
Pull Request Author: jhux2 |
For Tpetra deprecated code testing, there is no need to run the tests for Kokkos, Teuchos, or KokkosKernels.
jhux2
added
the
AT: RETEST
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.8.4 # 4339 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_intel_17.0.1 # 4161 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.9.3_SERIAL # 2600 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_7.2.0 # 2424 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_cuda_9.2 # 2001 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_python_2 # 455 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_python_3 # 455 (click to expand) |
kddevin
previously approved these changes
Aug 23, 2019
Set variable "Trilinos_PACKAGES" to just Tpetra. I think listing other packages matters, but just to be sure, I removed them.
kddevin
approved these changes
Aug 23, 2019
|
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
Using Repos:
Pull Request Author: jhux2 |
|
@trilinos/framework This pull request only affects Trilinos/cmake/ctest/drivers/rocketman, but the PR testing is running a full set of tests: https://testing.sandia.gov/cdash/index.php?project=Trilinos&filtercount=1&showfilters=1&field1=buildname&compare1=65&value1=PR-5789. This shouldn't happen, should it? |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
|
trilinos-autotester
removed
the
AT: RETEST
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ kddevin ]! |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Merge on Pull Request# 5789: IS A SUCCESS - Pull Request successfully merged |
trilinos-autotester
removed
the
AT: AUTOMERGE
The logs show this only tested MueLu. and only ran 664 tests, so no it did not test everything, just about 1/2 which I believe is correct. |
@prwolfe This PR only changed files in Trilinos/cmake/ctest/drivers/rocketman. It doesn't touch Trilinos source code. Why did changes to the ctest drivers prompt any recompilation/testing at all? Previously, these changes would have gone through after approval without any recompilation/testing. See, for example, PR #5761. |
|
@jhux2 - sorry I had not looked at the diffs when I wrote that. I don't expect this to have needed to test anything actually. We rely on tribits to set the testing list, and I would expect this directory to be all or nothing, not MueLU only. I will look a bit. |
prwolfe
added a commit
to prwolfe/Trilinos
that referenced
this pull request
Aug 28, 2019
I missed this during the transition to python and jhux found the issue in trilinos#5789
4 tasks
prwolfe
added a commit
to prwolfe/Trilinos
that referenced
this pull request
Aug 28, 2019
I missed this during the transition to python and jhux found the issue in trilinos#5789
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress for #5787
This change is