Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MueLu: fixing the Zoltan unit-test for static allocation of Tpetra::CrsGraph see issue #5614 #5620

Merged
merged 1 commit into from
Aug 1, 2019
Merged

MueLu: fixing the Zoltan unit-test for static allocation of Tpetra::CrsGraph see issue #5614 #5620

merged 1 commit into from
Aug 1, 2019

Conversation

lucbv
Copy link
Contributor

@lucbv lucbv commented Jul 31, 2019

@trilinos/muelu

Description

The matrix in unit-test Zoltan_Build is now properly estimating the number of non-zeros per row which allows to be built without crashing with the new static allocation of the Tpetra::CrsGraph

Motivation and Context

This work will make the test pass after Tpetra removes its deprecated code.

Related Issues

How Has This Been Tested?

I performed a local build and the test is now passing correctly.

Checklist

  • My commit messages mention the appropriate GitHub issue numbers.
  • My code follows the code style of the affected package(s).
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the code contribution guidelines for this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • No new compiler warnings were introduced.
  • These changes break backwards compatibility.

@lucbv lucbv added type: bug The primary issue is a bug in Trilinos code or tests pkg: MueLu AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed labels Jul 31, 2019
@lucbv lucbv requested review from tjfulle, cgcgcg, csiefer2 and jhux2 July 31, 2019 23:27
@lucbv lucbv requested a review from a team as a code owner July 31, 2019 23:27
@lucbv lucbv self-assigned this Jul 31, 2019
@lucbv
MueLu: fixing the Zoltan unit-test for static allocation of Tpetra::C…
11af215 
…rsGraph see issue trilinos#5614

This work will make the test pass after Tpetra removes its deprecated code.
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 4120
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 5620
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH MueLu_fix_unit_test_Tpetra_deprecation
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA 11af215
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0df5cc0

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 3941
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5620
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH MueLu_fix_unit_test_Tpetra_deprecation
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA 11af215
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0df5cc0

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 2381
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5620
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH MueLu_fix_unit_test_Tpetra_deprecation
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA 11af215
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0df5cc0

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 2197
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5620
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH MueLu_fix_unit_test_Tpetra_deprecation
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA 11af215
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0df5cc0

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 1782
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
JENKINS_JOB_TYPE Experimental
PULLREQUESTNUM 5620
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH MueLu_fix_unit_test_Tpetra_deprecation
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA 11af215
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0df5cc0

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 262
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5620
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH MueLu_fix_unit_test_Tpetra_deprecation
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA 11af215
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0df5cc0

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 262
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5620
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH MueLu_fix_unit_test_Tpetra_deprecation
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA 11af215
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0df5cc0

Using Repos:

Repo: TRILINOS (lucbv/Trilinos)
  • Branch: MueLu_fix_unit_test_Tpetra_deprecation
  • SHA: 11af215
  • Mode: TEST_REPO

Pull Request Author: lucbv

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 4120
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 5620
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH MueLu_fix_unit_test_Tpetra_deprecation
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA 11af215
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0df5cc0

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 3941
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5620
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH MueLu_fix_unit_test_Tpetra_deprecation
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA 11af215
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0df5cc0

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 2381
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5620
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH MueLu_fix_unit_test_Tpetra_deprecation
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA 11af215
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0df5cc0

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 2197
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5620
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH MueLu_fix_unit_test_Tpetra_deprecation
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA 11af215
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0df5cc0

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 1782
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
JENKINS_JOB_TYPE Experimental
PULLREQUESTNUM 5620
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH MueLu_fix_unit_test_Tpetra_deprecation
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA 11af215
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0df5cc0

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 262
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5620
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH MueLu_fix_unit_test_Tpetra_deprecation
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA 11af215
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0df5cc0

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 262
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5620
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH MueLu_fix_unit_test_Tpetra_deprecation
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA 11af215
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0df5cc0


CDash Test Results for PR# 5620.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ cgcgcg ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester trilinos-autotester merged commit 90b0f99 into trilinos:develop Aug 1, 2019
@trilinos-autotester
Copy link
Contributor

Merge on Pull Request# 5620: IS A SUCCESS - Pull Request successfully merged

@trilinos-autotester trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Aug 1, 2019
@tjfulle tjfulle mentioned this pull request Aug 1, 2019
Closed
18 tasks
@lucbv lucbv deleted the MueLu_fix_unit_test_Tpetra_deprecation branch August 5, 2019 13:48
@trilinos-autotester trilinos-autotester mentioned this pull request Sep 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgcgcg cgcgcg cgcgcg approved these changes

@tjfulle tjfulle Awaiting requested review from tjfulle

@csiefer2 csiefer2 Awaiting requested review from csiefer2

@jhux2 jhux2 Awaiting requested review from jhux2

Assignees

@lucbv lucbv

Labels
pkg: MueLu type: bug The primary issue is a bug in Trilinos code or tests
Projects
MueLu
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucbv @trilinos-autotester @cgcgcg