Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Teuchos: replacing not with ! for MSVC compiler #5190

Merged
merged 1 commit into from
May 16, 2019
Merged

Teuchos: replacing not with ! for MSVC compiler #5190

merged 1 commit into from
May 16, 2019

Conversation

lucbv
Copy link
Contributor

@lucbv lucbv commented May 16, 2019

@csiefer2

Description

Fix code for MSVC

Motivation and Context

This helps Trilinos toward building on windows platforms

@lucbv lucbv added type: bug The primary issue is a bug in Trilinos code or tests pkg: Teuchos Issues primarily dealing with the Teuchos Package AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed labels May 16, 2019
@lucbv lucbv requested a review from csiefer2 May 16, 2019 13:31
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 3587
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 5190
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Teuchos_remove_not
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA 48861b2
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0aa8b3c

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 3414
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5190
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Teuchos_remove_not
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA 48861b2
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0aa8b3c

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 1859
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5190
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Teuchos_remove_not
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA 48861b2
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0aa8b3c

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 1620
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5190
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Teuchos_remove_not
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA 48861b2
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0aa8b3c

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 1265
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
JENKINS_JOB_TYPE Experimental
PULLREQUESTNUM 5190
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Teuchos_remove_not
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA 48861b2
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0aa8b3c

Using Repos:

Repo: TRILINOS (lucbv/Trilinos)
  • Branch: Teuchos_remove_not
  • SHA: 48861b2
  • Mode: TEST_REPO

Pull Request Author: lucbv

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 3587
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 5190
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Teuchos_remove_not
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA 48861b2
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0aa8b3c

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 3414
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5190
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Teuchos_remove_not
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA 48861b2
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0aa8b3c

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 1859
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5190
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Teuchos_remove_not
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA 48861b2
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0aa8b3c

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 1620
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5190
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Teuchos_remove_not
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA 48861b2
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0aa8b3c

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 1265
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
JENKINS_JOB_TYPE Experimental
PULLREQUESTNUM 5190
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Teuchos_remove_not
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA 48861b2
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 0aa8b3c


CDash Test Results for PR# 5190.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ csiefer2 ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester trilinos-autotester merged commit 3886ba7 into trilinos:develop May 16, 2019
@trilinos-autotester
Copy link
Contributor

Merge on Pull Request# 5190: IS A SUCCESS - Pull Request successfully merged

@trilinos-autotester trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label May 16, 2019
@lucbv lucbv deleted the Teuchos_remove_not branch May 16, 2019 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csiefer2 csiefer2 csiefer2 approved these changes

Assignees
No one assigned
Labels
pkg: Teuchos Issues primarily dealing with the Teuchos Package type: bug The primary issue is a bug in Trilinos code or tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucbv @trilinos-autotester @csiefer2