Tpetra::MultiVector: Fix #4870 (prefer running norms on device) #4885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 14, 2019 11:52
@trilinos/tpetra I also factored out the implementation of Tpetra::MultiVector::norm* into a separate function, Tpetra::Details::normImpl. I do ETI for that function, when ETI is enabled. This required adding new ETI macros for iterating over the (Scalar, Node) type combination.
@trilinos/stokhos @trilinos/tpetra This is part of the fix for #4870.
@trilinos/stokhos @trilinos/tpetra This is part of the fix for #4870.
mhoemmen
requested review from
william76,
tjfulle,
cgcgcg,
kyungjoo-kim,
csiefer2,
etphipp,
crtrott,
kddevin,
GeoffDanielson,
jhux2 and
lucbv
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Using Repos:
Pull Request Author: mhoemmen |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.8.4 # 3239 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_intel_17.0.1 # 3068 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.9.3_SERIAL # 1515 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_7.2.0 # 1251 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_cuda_9.2 # 930 (click to expand) |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Using Repos:
Pull Request Author: mhoemmen |
|
Huh, it looks like these build errors are also legit. For the Cuda case, I need to add additional explicit instantiations to Stokhos for host execution space access of the host mirror space (which happens to be Also, surprise, GCC 7.2.0 has different warnings than other compilers, and it's a warnings-as-errors build: |
mhoemmen
added
the
AT: WIP
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.8.4 # 3240 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_intel_17.0.1 # 3069 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.9.3_SERIAL # 1516 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_7.2.0 # 1252 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_cuda_9.2 # 931 (click to expand) |
|
Superseded by #4899. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trilinos/tpetra @trilinos/stokhos @vbrunini @etphipp
Superseded by #4899. Supersedes PR #4881 and PR #4871.
Description
Tpetra::MultiVectornorms on device, even if it is currently sync'd to host, unless the vector has too few local rows.Tpetra::MultiVector::norm*into a separate function,Tpetra::Details::normImpl. I do ETI for that function, when ETI is enabled. This required adding new ETI macros for iterating over the(Scalar, Node)type combination.Tpetra::Details::normImpl.To elaborate the last point: Tpetra's ETI macro for
Tpetra::Details::normImplonly takes 2 template parameters:ScalarandNode. This meant that I couldn't use Stokhos' ETI system directly (seeTPETRA_ETI_CLASSESinstokhos/src/CMakeLists.txt). I had to take different approaches for PCE types vs.MP::Vectortypes. My solution for PCE types looks more permanent (read "is less of a hack") than my solution forMP::Vectortypes; it would be great if @etphipp could comment.Motivation and Context
Related Issues