Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tpetra: Fix #4199 #4200

Merged
merged 2 commits into from
Jan 16, 2019
Merged

Tpetra: Fix #4199 #4200

merged 2 commits into from
Jan 16, 2019

Conversation

mhoemmen
Copy link
Contributor

@trilinos/tpetra @kddevin @csiefer2 @trilinos/muelu
sorry for brevity, I have to type this on phone, could someone plz review and label as auto merge? Thanks :-)

Description

Motivation and Context

Related Issues

How Has This Been Tested?

Checklist

  • My commit messages mention the appropriate GitHub issue numbers.
  • My code follows the code style of the affected package(s).
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the code contribution guidelines for this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • No new compiler warnings were introduced.
  • These changes break backwards compatibility.

Mark Hoemmen added 2 commits January 15, 2019 17:34
Tpetra::DistObject::doTransfer*: Improve verbose output
8b2c633 
@trilinos/tpetra
Tpetra: Fix #4199
56bb5d6 
@trilinos/tpetra

Change Tpetra's getArrayViewFromDualView helper function, so that if
the View has a zero length, Teuchos::ArrayView's constructor gets
called as ArrayView(nullptr,0).  This is needed because ArrayView's
constructor throws an exception in debug mode, if given (nonnull,0).
@bartlettroscoe bartlettroscoe added the stage: in progress Work on the issue has started label Jan 16, 2019
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 2247
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 4200
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Fix-4199
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 56bb5d6
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d3a1bbd

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 2050
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4200
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Fix-4199
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 56bb5d6
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d3a1bbd

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 537
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4200
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Fix-4199
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 56bb5d6
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d3a1bbd

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 148
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4200
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Fix-4199
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 56bb5d6
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d3a1bbd

Using Repos:

Repo: TRILINOS (trilinos/Trilinos)
  • Branch: Fix-4199
  • SHA: 56bb5d6
  • Mode: TEST_REPO

Pull Request Author: mhoemmen

@csiefer2 csiefer2 added the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Jan 16, 2019
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 2247
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 4200
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Fix-4199
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 56bb5d6
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d3a1bbd

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 2050
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4200
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Fix-4199
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 56bb5d6
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d3a1bbd

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 537
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4200
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Fix-4199
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 56bb5d6
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d3a1bbd

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 148
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4200
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Fix-4199
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 56bb5d6
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d3a1bbd


CDash Test Results for PR# 4200.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ csiefer2 ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester trilinos-autotester merged commit 72efa87 into develop Jan 16, 2019
@trilinos-autotester
Copy link
Contributor

Merge on Pull Request# 4200: IS A SUCCESS - Pull Request successfully merged

@trilinos-autotester trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Jan 16, 2019
@bartlettroscoe bartlettroscoe removed the stage: in progress Work on the issue has started label Jan 16, 2019
@mhoemmen mhoemmen deleted the Fix-4199 branch August 1, 2019 17:46
@trilinos-autotester trilinos-autotester mentioned this pull request Dec 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csiefer2 csiefer2 csiefer2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mhoemmen @trilinos-autotester @csiefer2 @bartlettroscoe