Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thyra: add function to reset the ModelEvaluatorDefaultBase lazy initialization flag #4198

Merged
merged 1 commit into from
Jan 16, 2019
Merged

Thyra: add function to reset the ModelEvaluatorDefaultBase lazy initialization flag #4198

merged 1 commit into from
Jan 16, 2019

Conversation

rppawlo
Copy link
Contributor

@rppawlo rppawlo commented Jan 15, 2019

This change allows Drekar to run correctly with Trilinos_ENABLE_DEBUG=ON (in particular IMEX and adjoint problems).

Details on why this is needed are in the new unit test.

@rppawlo rppawlo added pkg: Thyra Issues primarily dealing with the Thyra Package pkg: Panzer AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed PA: Nonlinear Solvers Issues that fall under the Trilinos Nonlinear Linear Solvers Product Area labels Jan 15, 2019
@rppawlo rppawlo self-assigned this Jan 15, 2019
@rppawlo rppawlo requested a review from a team as a code owner January 15, 2019 22:37
@bartlettroscoe bartlettroscoe added the stage: in progress Work on the issue has started label Jan 15, 2019
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 2246
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 4198
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH thyra-fix
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA ca06dab
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 67ed9e6

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 2049
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4198
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH thyra-fix
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA ca06dab
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 67ed9e6

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 536
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4198
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH thyra-fix
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA ca06dab
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 67ed9e6

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 147
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4198
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH thyra-fix
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA ca06dab
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 67ed9e6

Using Repos:

Repo: TRILINOS (rppawlo/Trilinos)
  • Branch: thyra-fix
  • SHA: ca06dab
  • Mode: TEST_REPO

Pull Request Author: rppawlo

bartlettroscoe
bartlettroscoe approved these changes Jan 15, 2019
View reviewed changes
Copy link
Member

@bartlettroscoe bartlettroscoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rppawlo, does this mean that we can try setting Trilinos_ENABLE_DEBUG=ON in the ATDM Trilinos debug builds? This would improve the checking that Trilinos and APP developers get when doing development work (and the test cost should not be that much higher).

Now that I can test against SPARC and EMPIRE, we can test this against the ATDM apps. Is that worth trying this with ATDM after this PR is merged?

@rppawlo
Copy link
Contributor Author

rppawlo commented Jan 16, 2019

@bartlettroscoe - Trilinos_ENABLE_DEBUG=ON should already work for EMPIRE (and Panzer) builds. Both Matt and I use them regularly without any problems. The automated builds of empire trilinos always do a debug-debug version with that flag enabled as far as I know (unless something changed recently). This push is for Drekar for some corner cases. This finally allows Drekar's test suite to pass all tests with Trilinos_ENABLE_DEBUG=ON.

@rppawlo
Copy link
Contributor Author

rppawlo commented Jan 16, 2019

Is that worth trying this with ATDM after this PR is merged?

yes

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 2246
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 4198
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH thyra-fix
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA ca06dab
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 67ed9e6

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 2049
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4198
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH thyra-fix
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA ca06dab
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 67ed9e6

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 536
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4198
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH thyra-fix
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA ca06dab
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 67ed9e6

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 147
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4198
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH thyra-fix
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA ca06dab
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 67ed9e6


CDash Test Results for PR# 4198.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ bartlettroscoe jmgate ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester trilinos-autotester merged commit ede1539 into trilinos:develop Jan 16, 2019
@trilinos-autotester
Copy link
Contributor

Merge on Pull Request# 4198: IS A SUCCESS - Pull Request successfully merged

@trilinos-autotester trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Jan 16, 2019
@bartlettroscoe bartlettroscoe removed the stage: in progress Work on the issue has started label Jan 16, 2019
@bartlettroscoe bartlettroscoe mentioned this pull request Jan 16, 2019
Closed
@rppawlo rppawlo deleted the thyra-fix branch July 22, 2019 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlettroscoe bartlettroscoe bartlettroscoe approved these changes

@jmgate jmgate jmgate approved these changes

Assignees

@rppawlo rppawlo

Labels
PA: Nonlinear Solvers Issues that fall under the Trilinos Nonlinear Linear Solvers Product Area pkg: Panzer pkg: Thyra Issues primarily dealing with the Thyra Package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rppawlo @trilinos-autotester @bartlettroscoe @jmgate