Bring recent stk development from Sierra into Trilinos. #3938
Conversation
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Using Repos:
Pull Request Author: alanw0 |
| } | ||
| catch(std::exception& e) | ||
| { | ||
| std::cerr<<e.what()<<std::endl; |
There was a problem hiding this comment.
Consider returning a nonzero error code in this case. That would make scripting easier.
| input_file_index >= file_vector.size() || | ||
| Teuchos::is_null(file_vector[input_file_index]); | ||
| input_file_index >= file_vector.size() || | ||
| Teuchos::is_null(file_vector[input_file_index]); |
There was a problem hiding this comment.
It's not really just any old T; it's actually something more like Teuchos::RCP<T>, right? It would be better to constrain T in the interface than in the implementation.
| for (stk::mesh::FieldBase * field : fields) { | ||
| const unsigned fieldOrdinal = field->mesh_meta_data_ordinal(); | ||
|
|
||
| if (field->type_is<double>()) { |
There was a problem hiding this comment.
For the future, keep in mind std::variant and std::visit.
| typedef Kokkos::View<stk::mesh::Entity*, MemSpace> EntityViewType; | ||
| typedef Kokkos::View<stk::mesh::Entity**, MemSpace> BucketConnectivityType; | ||
| typedef Kokkos::View<unsigned*, MemSpace> UnsignedViewType; |
| @@ -74,14 +74,7 @@ struct ReductionTeamFunctor | |||
| JoinOp (value_type& value_) : value (&value_) {} | |||
|
|
|||
There was a problem hiding this comment.
I'm not sure if you're suppose to keep a pointer to the value inside the reduction functor. The result is just the output of team parallel_reduce, right?
There was a problem hiding this comment.
@mhoemmen thanks for the comments, we will incorporate them!
|
I want to see the builds. The recent stk builds on the Sierra dashboard are showing a lot of build failures (27). Why do we not expect them here? |
|
@prwolfe I will be interested to see the builds also. The dashboard errors appear to be some missing boost headers (file-system issue?) and undefined references to functions that have been moved to different files within the same library (stk_io). Possible issue with continuous/incremental build? I don't know, but we've been routinely building stk for a couple of different builds without issue. It could be an issue in the cmake files, in which case we'll find out with these PR builds... |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Console Output (last 100 lines) : Trilinos_pullrequest_intel_17.0.1 # 1732 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.9.3 # 2297 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.8.4 # 1958 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.9.3_SERIAL # 269 (click to expand) |
|
@prwolfe Looks like builds failed, but I can't see anything stk-related. Don't know how to fix this... |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Using Repos:
Pull Request Author: alanw0 |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Console Output (last 100 lines) : Trilinos_pullrequest_intel_17.0.1 # 1736 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.9.3 # 2301 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.8.4 # 1962 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.9.3_SERIAL # 273 (click to expand) |
|
@alanw0 Looks like a legit SIGSEGV: |
|
@mhoemmen It sure does. Maybe you can teach me how to find that output. I still can't find it, I've been clicking all over the place. |
|
@alanw0 Click on the "CDash Test Results for PR# 3938." link and look for the red test failures. |
and also adjust some ngp unit-tests to only run on 1 MPI proc.
|
Thanks @mhoemmen I've now attempted to address that. |
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Using Repos:
Pull Request Author: alanw0 |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Console Output (last 100 lines) : Trilinos_pullrequest_intel_17.0.1 # 1743 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.9.3 # 2308 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.8.4 # 1969 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.9.3_SERIAL # 280 (click to expand) |
Adjust a couple of unit-tests to not run in parallel when they are not meant to.
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Using Repos:
Pull Request Author: alanw0 |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Console Output (last 100 lines) : Trilinos_pullrequest_intel_17.0.1 # 1746 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.9.3 # 2311 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.8.4 # 1972 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.9.3_SERIAL # 283 (click to expand) |
|
Status Flag 'Pull Request AutoTester' - Failure: Timed out waiting for job Trilinos_pullrequest_gcc_4.9.3_SERIAL to start: Total Wait = 603
|
|
@mhoemmen Yes it turns out that our sierra unit-tests run with filters that exclude some, and only run some on 1 proc, etc. Whereas the cmake/ctest system runs them differently... We will clean this up, and probably uncover some bugs to fix in the process. |
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Using Repos:
Pull Request Author: alanw0 |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ mhoemmen ]! |
|
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
* Bring recent stk development from Sierra into Trilinos. * Tweak some cmake files to add dependence on stk_util_util and also adjust some ngp unit-tests to only run on 1 MPI proc.
@trilinos/
Description
Motivation and Context
How Has This Been Tested?
Checklist