-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Framework: Make Kokkos-Kernels build in PR testing..." #3814
Conversation
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Using Repos:
Pull Request Author: william76 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want this change in.
To elaborate: besides the additional comment about Not Merging in in the code, this is the change the Kokkos team recommended in the github issue to be done for now. We merged this morning a new Kokkos and KokkosKernels release into Trilinos, and this issue here is potentially masking problems with that new release. I talked to Siva about this and as the code owners for Kokkos we decided this is the right thing to do for now. Issuing another pull request to just have the comment not be in the code felt rather excessive, in particular since it is not clear that the testing will be finished before nightlies go off. So we decided to merge. |
ok, fine. I'll cancel this revert. But... In the future, please do not just add automerge tags, etc. to Framework team pull requests if you aren't part of the discussion we've had in our meetings about what our goals are in that PR without a conversation with us about it first. There is more going on with that PR than simply implementing the change we discussed in the other issue ticket, which is why I wanted to have an opportunity to review the output before doing anything. That is exactly why I made notes in many places to tell people to NOT merge that PR. It has happened a few times before where non framework folks have merged our PR's without consulting us first... I find it greatly annoying since if I'm wanting to merge immediately after testing is done without reviewing the results, I will set the AT:AUTOMERGE flag myself. |
Status Flag 'Pull Request AutoTester' - Error: Jenkins Jobs - A user has closed the PR before testing completed. The Jenkins Jobs will be shutdown |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Console Output (last 100 lines) : Trilinos_pullrequest_intel_17.0.1 # 1593 (click to expand)
Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.9.3 # 2156 (click to expand)
Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.8.4 # 1818 (click to expand)
Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.9.3_SERIAL # 131 (click to expand)
|
Reverts #3803 because people don't read.