Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ML: Issue 3565 #3656

Merged
merged 1 commit into from
Oct 18, 2018
Merged

ML: Issue 3565 #3656

merged 1 commit into from
Oct 18, 2018

Conversation

rhoope
Copy link
Contributor

@rhoope rhoope commented Oct 17, 2018

Fix to allow user-supplied MPI_Comm in the C-API.

@trilinos/
Request review by @csiefer2

Description

The C-API for MLCreate was hard-coded to use MPI_COMM_WORLD which breaks MPMD uses.

Motivation and Context

Closes Issue #3565

How Has This Been Tested?

I ran the application code in MPMD code to verify the previous error is no longer encountered.

Checklist

  • [ x] My commit messages mention the appropriate GitHub issue numbers.
  • [x ] My code follows the code style of the affected package(s).
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the code contribution guidelines for this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • [x ] No new compiler warnings were introduced.
  • These changes break backwards compatibility.

Fix to allow user-supplied MPI_Comm in the C-API.
@jhux2 jhux2 requested review from jhux2 and csiefer2 October 17, 2018 19:41
@jhux2 jhux2 added the pkg: ML label Oct 17, 2018
@jhux2 jhux2 requested a review from rstumin October 17, 2018 19:42
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ csiefer2 ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 1410
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 3656
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH ml_issue3565
TRILINOS_SOURCE_REPO https://github.com/rhoope/Trilinos
TRILINOS_SOURCE_SHA c17aa9e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8d56e74

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

  • Build Num: 1973
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.9.3
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 3656
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH ml_issue3565
TRILINOS_SOURCE_REPO https://github.com/rhoope/Trilinos
TRILINOS_SOURCE_SHA c17aa9e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8d56e74

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 1635
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 3656
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH ml_issue3565
TRILINOS_SOURCE_REPO https://github.com/rhoope/Trilinos
TRILINOS_SOURCE_SHA c17aa9e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8d56e74

Using Repos:

Repo: TRILINOS (rhoope/Trilinos)
  • Branch: ml_issue3565
  • SHA: c17aa9e
  • Mode: TEST_REPO

Pull Request Author: rhoope

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 1410
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 3656
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH ml_issue3565
TRILINOS_SOURCE_REPO https://github.com/rhoope/Trilinos
TRILINOS_SOURCE_SHA c17aa9e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8d56e74

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

  • Build Num: 1973
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.9.3
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 3656
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH ml_issue3565
TRILINOS_SOURCE_REPO https://github.com/rhoope/Trilinos
TRILINOS_SOURCE_SHA c17aa9e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8d56e74

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 1635
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 3656
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH ml_issue3565
TRILINOS_SOURCE_REPO https://github.com/rhoope/Trilinos
TRILINOS_SOURCE_SHA c17aa9e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 8d56e74


CDash Test Results for PR# 3656.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ csiefer2 ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR...

@jhux2 jhux2 merged commit c92f0bc into trilinos:develop Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants