Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Atdm mutrino use sbatch #2946

Merged
merged 4 commits into from
Jun 15, 2018
Merged

Atdm mutrino use sbatch #2946

merged 4 commits into from
Jun 15, 2018

Conversation

fryeguy52
Copy link
Contributor

@fryeguy52 fryeguy52 commented Jun 14, 2018 •
edited by bartlettroscoe
Loading

Description

This does a few small things for the ATDM configuration

  1. Switch the mutrino jobs to use sbatch. This change seems to fix several of the failing seacas tests in SEACAS tests failing in ATDM builds on mutrino #2815
  2. promote the full configuration jobs on chama to the ATDM CDash Group. Which are both passing all tests today as shown here
  3. Disable the test Piro_MatrixFreeDecorator_UnitTests_MPI_4_DISABLE on both serrano and mutrino because it is failing randomly as described in Test Piro_MatrixFreeDecorator_UnitTests_MPI_4 failing in several ATDM builds #2474

fryeguy52 added 4 commits June 13, 2018 13:43
@fryeguy52
switch ATDM mutrino build to use sbatch
ff791f8
@fryeguy52
disabled randomly failing test for ATDM builds on serrano
46d2173 
modified tweaks file to include:
ATDM_SET_ENABLE(Piro_MatrixFreeDecorator_UnitTests_MPI_4_DISABLE ON)
@fryeguy52
disabled randomly failing test for ATDM builds on mutrino
dabde9f 
added tweaks files that include:
ATDM_SET_ENABLE(Piro_MatrixFreeDecorator_UnitTests_MPI_4_DISABLE ON)
@fryeguy52
promote the ATDM chama builds to 'ATDM' cdash group
36a514a 
the two full builds on chama were clean last night so this will
promote them to the ATDM track on the cdash site
@fryeguy52 fryeguy52 requested a review from bartlettroscoe June 14, 2018 20:31
@bartlettroscoe bartlettroscoe added the client: ATDM Any issue primarily impacting the ATDM project label Jun 14, 2018
bartlettroscoe
bartlettroscoe reviewed Jun 14, 2018
View reviewed changes
cmake/std/atdm/mutrino/environment.sh
# still has to work. So the script has to use absolute directory paths, not
# relative paths or asume sym links, etc.
#
function atdm_run_script_on_compute_node {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fryeguy52, this function atdm_run_script_on_compute_node looks identical char-for-char identical to the one in cmake/std/atdm/toss3/environment.sh. Is that correct? Was it a complete 100% copy and paste? If that is the case, we should factor this function out into its own file and then include it in cmake/std/atdm/toss3/environment.sh and cmake/std/atdm/mutrino/environment.sh in a follow-up refactoring and PR (I don't want to delay getting this PR merged so that we can see this running tomorrow).

bartlettroscoe
bartlettroscoe reviewed Jun 14, 2018
View reviewed changes
cmake/ctest/drivers/atdm/mutrino/local-driver.sh
$PWD/ctest-s-driver-test.out \
${SALLOC_CTEST_TIME_LIMIT_MINUTES}

#/usr/local/bin/salloc -N 1 -p standard -J $JOB_NAME \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fryeguy52, we should remove this commented-out command in a follow-up commit and PR (I don't want to holdup the merge of this PR). Git can show this change better than a comment like this.

bartlettroscoe
bartlettroscoe approved these changes Jun 14, 2018
View reviewed changes
Copy link
Member

@bartlettroscoe bartlettroscoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fryeguy52, other than some duplication in the function atdm_run_script_on_compute_node (which we can clean up in a follow-up commit and PR), this looks great. Hopefully that auto PR testing will pass the first time so that I can merge this before automated testing starts tomorrow.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

  • Build Num: 851
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.9.3
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2946
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH atdm-mutrino-use-sbatch
TRILINOS_SOURCE_REPO https://github.com/fryeguy52/Trilinos
TRILINOS_SOURCE_SHA 36a514a
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13fe1e6

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 568
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2946
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH atdm-mutrino-use-sbatch
TRILINOS_SOURCE_REPO https://github.com/fryeguy52/Trilinos
TRILINOS_SOURCE_SHA 36a514a
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13fe1e6

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 116
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 2946
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH atdm-mutrino-use-sbatch
TRILINOS_SOURCE_REPO https://github.com/fryeguy52/Trilinos
TRILINOS_SOURCE_SHA 36a514a
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13fe1e6

Using Repos:

Repo: TRILINOS (fryeguy52/Trilinos)
  • Branch: atdm-mutrino-use-sbatch
  • SHA: 36a514a
  • Mode: TEST_REPO

Pull Request Author: fryeguy52

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

  • Build Num: 851
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.9.3
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2946
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH atdm-mutrino-use-sbatch
TRILINOS_SOURCE_REPO https://github.com/fryeguy52/Trilinos
TRILINOS_SOURCE_SHA 36a514a
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13fe1e6

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 568
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2946
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH atdm-mutrino-use-sbatch
TRILINOS_SOURCE_REPO https://github.com/fryeguy52/Trilinos
TRILINOS_SOURCE_SHA 36a514a
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13fe1e6

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 116
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 2946
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH atdm-mutrino-use-sbatch
TRILINOS_SOURCE_REPO https://github.com/fryeguy52/Trilinos
TRILINOS_SOURCE_SHA 36a514a
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 13fe1e6


CDash Test Results for PR# 2946.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ bartlettroscoe ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Master Automerge is disabled (in .cfg file)

@bartlettroscoe bartlettroscoe merged commit 3b15578 into trilinos:develop Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlettroscoe bartlettroscoe bartlettroscoe approved these changes

Assignees
No one assigned
Labels
client: ATDM Any issue primarily impacting the ATDM project
Projects
None yet
Milestone
Initial cleanup of new ATDM builds of...
Development

Successfully merging this pull request may close these issues.
3 participants
@fryeguy52 @trilinos-autotester @bartlettroscoe