Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temp disable three ShyLU_DD tests for this OpenMP build (#2691) #2841

Merged
merged 1 commit into from
May 30, 2018
Merged

Temp disable three ShyLU_DD tests for this OpenMP build (#2691) #2841

merged 1 commit into from
May 30, 2018

Conversation

bartlettroscoe
Copy link
Member

CC: @trilinos/shylu, @trilinos/framework

Description

The addresses #2691.

These disables will allows this build to be promoted to the CI build and an
auto PR build (see #2462).

Motivation and Context

ShyLU developers have not been able to reproduce and fix yet. Temporarily disabling in this one (and only this one) build is the best option. The GCC 4.9.3 serial Kokkos auto PR build will still run these tests.

Related Issues

How Has This Been Tested?

While on this branch, I tested this as described in the "Steps to Reproduce" section in #2691 on my CEE LAN machine 'ceerws1113' and the configure output showed:

Processing enabled package: ShyLU_DD (FROSch, Tests, Examples)
-- ShyLU_DDFROSch_test_frosch_laplacian_epetra_2d_gdsw_MPI_4: NOT added test because ShyLU_DDFROSch_test_frosch_laplacian_epetra_2d_gdsw_MPI_4_DISABLE='TRUE'!
-- ShyLU_DDFROSch_test_frosch_laplacian_epetra_3d_gdsw: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_frosch_laplacian_epetra_2d_rgdsw_MPI_4: NOT added test because ShyLU_DDFROSch_test_frosch_laplacian_epetra_2d_rgdsw_MPI_4_DISABLE='TRUE'!
-- ShyLU_DDFROSch_test_frosch_laplacian_epetra_3d_rgdsw: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_frosch_laplacian_tpetra_2d_gdsw_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_frosch_laplacian_tpetra_3d_gdsw: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_frosch_laplacian_tpetra_2d_rgdsw_MPI_4: Added test (BASIC, NUM_MPI_PROCS=4, PROCESSORS=4)!
-- ShyLU_DDFROSch_test_frosch_laplacian_tpetra_3d_rgdsw: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!
-- ShyLU_DDFROSch_test_frosch_interfacesets_2D_MPI_4: NOT added test because ShyLU_DDFROSch_test_frosch_interfacesets_2D_MPI_4_DISABLE='TRUE'!
-- ShyLU_DDFROSch_test_frosch_interfacesets_3D: NOT added test because NUM_MPI_PROCS='8' > MPI_EXEC_MAX_NUMPROCS='4'!

and the test output showed:

Test project /scratch/rabartl/Trilinos.base/BUILDS/GCC-4.8.4/MPI_RELEASE_DEBUG_SHARED_PT_OPENMP
    Start 1: ShyLU_DDFROSch_test_frosch_laplacian_tpetra_2d_gdsw_MPI_4
    Start 2: ShyLU_DDFROSch_test_frosch_laplacian_tpetra_2d_rgdsw_MPI_4
1/2 Test #1: ShyLU_DDFROSch_test_frosch_laplacian_tpetra_2d_gdsw_MPI_4 ....   Passed    0.88 sec
2/2 Test #2: ShyLU_DDFROSch_test_frosch_laplacian_tpetra_2d_rgdsw_MPI_4 ...   Passed    0.89 sec

100% tests passed, 0 tests failed out of 2

Subproject Time Summary:
ShyLU_DD    =   7.10 sec*proc (2 tests)

Total Test time (real) =   0.90 sec

Checklist

  • My commit messages mention the appropriate GitHub issue numbers.
  • All new and existing tests passed.

@bartlettroscoe
Temp disable three ShyLU_DD tests for this OpenMP build (trilinos#2691)
06bbebd 
These disables will allows this build to be promoted to the CI build and an
auto PR build (see trilinos#2462).
@bartlettroscoe bartlettroscoe added Framework tasks Framework tasks (used internally by Framework team) pkg: ShyLU labels May 30, 2018
@bartlettroscoe bartlettroscoe mentioned this pull request May 30, 2018
Closed
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

  • Build Num: 740
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.9.3
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2841
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 2691-disable-failing-shylu-dd-openmp-tests
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA 06bbebd
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 10bded9

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 457
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2841
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 2691-disable-failing-shylu-dd-openmp-tests
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA 06bbebd
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 10bded9

Using Repos:

Repo: TRILINOS (bartlettroscoe/Trilinos)
  • Branch: 2691-disable-failing-shylu-dd-openmp-tests
  • SHA: 06bbebd
  • Mode: TEST_REPO

Pull Request Author: bartlettroscoe

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

  • Build Num: 740
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.9.3
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2841
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 2691-disable-failing-shylu-dd-openmp-tests
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA 06bbebd
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 10bded9

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 457
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2841
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 2691-disable-failing-shylu-dd-openmp-tests
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA 06bbebd
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 10bded9


CDash Test Results for PR# 2841.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

ndellingwood
ndellingwood approved these changes May 30, 2018
View reviewed changes
Copy link
Contributor

@ndellingwood ndellingwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bartlettroscoe !

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ ndellingwood mhoemmen ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Master Automerge is disabled (in .cfg file)

@mhoemmen mhoemmen merged commit 08230a3 into trilinos:develop May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhoemmen mhoemmen mhoemmen approved these changes

@ndellingwood ndellingwood ndellingwood approved these changes

@srajama1 srajama1 Awaiting requested review from srajama1

@searhein searhein Awaiting requested review from searhein

Assignees
No one assigned
Labels
Framework tasks Framework tasks (used internally by Framework team) pkg: ShyLU
Projects
None yet
Milestone
Improve productivity, stability, and ...
Development

Successfully merging this pull request may close these issues.
4 participants
@bartlettroscoe @trilinos-autotester @mhoemmen @ndellingwood