Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add troubleshooting section and warning about git versions and ~/.gitconfig files #2655

Merged

Conversation

bartlettroscoe
Copy link
Member

@bartlettroscoe bartlettroscoe commented Apr 27, 2018

CC: @fryeguy52, @eric-c-cyr

Description

Add troubling shooting section and fixing some other problems with cmake/std/atdm/README.md file

Motivation and Context

A user ran into a problem with their ~/.gitconfig file and the version of git loaded by Trilinos/cmake/std/atdm/load-env.sh (see #2652). I added this section to try to address that problem for future users.

How Has This Been Tested?

I viewed the rendered Markdown on GitHub on my branch.

Checklist

  • My commit messages mention the appropriate GitHub issue numbers.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

There was a broken link and other small issues that I fixed.
…linos#2652)

A user ran into a problem with their ~/.gitconfig file and the version of git
loaded by Trilinos/cmake/std/atdm/load-env.sh (see trilinos#2652).  I added this
section to try to address that problem for future users.
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

  • Build Num: 581
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.9.3
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2655
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 2652-warn-of-global-gitconfig
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA d4936b3
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA cd6dc17

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 298
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2655
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 2652-warn-of-global-gitconfig
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA d4936b3
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA cd6dc17

Using Repos:

Repo: TRILINOS (bartlettroscoe/Trilinos)
  • Branch: 2652-warn-of-global-gitconfig
  • SHA: d4936b3
  • Mode: TEST_REPO

Pull Request Author: bartlettroscoe

@jmgate
Copy link
Contributor

jmgate commented Apr 27, 2018

Should rhel6/environment.sh even be module loading git? Is there something specific in these scripts that requires a certain version of git? If not, we can probably just ditch that line, but if so, it might be better to replace that module load with some sort of

if git version < something; then
  # handle it
fi

Copy link
Contributor

@eric-c-cyr eric-c-cyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good description of the problem.

@bartlettroscoe
Copy link
Member Author

bartlettroscoe commented Apr 27, 2018

Should rhel6/environment.sh even be module loading git?

The issue is that older versions of git (like the default on the SNL COE RHEL6) can't even do an https:// clone of Trilinos from Github. And in the case of #2652, the problem is not that the developer's git is tool old, it is that it is too new (and therefore, they had settings in their ~/.gitconfig file that don't work with older versions of git).

Now we could consider breaking up these env scripts into two but that would seem to be more difficult to maintain. I think this issue with git is a bit unique in this sense.

@eric-c-cyr
Copy link
Contributor

Also, once I read the error message carefully the fix was obvious (modify my temporarily .gitconfig). If I were more patient, then @bartlettroscoe would never have even seen this problem!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

  • Build Num: 581
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.9.3
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2655
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 2652-warn-of-global-gitconfig
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA d4936b3
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA cd6dc17

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 298
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2655
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 2652-warn-of-global-gitconfig
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA d4936b3
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA cd6dc17


CDash Test Results for PR# 2655.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ eric-c-cyr ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Master Automerge is disabled (in .cfg file)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client: ATDM Any issue primarily impacting the ATDM project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants