-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add troubleshooting section and warning about git versions and ~/.gitconfig files #2655
Add troubleshooting section and warning about git versions and ~/.gitconfig files #2655
Conversation
There was a broken link and other small issues that I fixed.
…linos#2652) A user ran into a problem with their ~/.gitconfig file and the version of git loaded by Trilinos/cmake/std/atdm/load-env.sh (see trilinos#2652). I added this section to try to address that problem for future users.
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Using Repos:
Pull Request Author: bartlettroscoe |
Should if git version < something; then
# handle it
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good description of the problem.
The issue is that older versions of git (like the default on the SNL COE RHEL6) can't even do an https:// clone of Trilinos from Github. And in the case of #2652, the problem is not that the developer's git is tool old, it is that it is too new (and therefore, they had settings in their Now we could consider breaking up these env scripts into two but that would seem to be more difficult to maintain. I think this issue with git is a bit unique in this sense. |
Also, once I read the error message carefully the fix was obvious (modify my temporarily .gitconfig). If I were more patient, then @bartlettroscoe would never have even seen this problem! |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ eric-c-cyr ]! |
Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Master Automerge is disabled (in .cfg file) |
CC: @fryeguy52, @eric-c-cyr
Description
Add troubling shooting section and fixing some other problems with cmake/std/atdm/README.md file
Motivation and Context
A user ran into a problem with their ~/.gitconfig file and the version of git loaded by Trilinos/cmake/std/atdm/load-env.sh (see #2652). I added this section to try to address that problem for future users.
How Has This Been Tested?
I viewed the rendered Markdown on GitHub on my branch.
Checklist