Reduce storge depth from 10 to 2 to reduce condition number and make portable (#2247) #2388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlettroscoe
added
AT: WIP
…portable (trilinos#2247) This change reduces the condition number of the least-squares problem from 10^12 to 10^4 and results in more stable floating point computations and better portability of the test. This fixes the failures with the Intel compiler 17.0.1 with optimized compiler flags (see trilinos#2247). Also has to change number of expected iterations from 18 to 11. I tested this with Intel and GNU builds and they both passed: Enabled Packages: NOX Enabled all Forward Packages 1) intel-opt-openmp => passed: passed=105,notpassed=0 (2.65 min) 2) gnu-opt-openmp => passed: passed=105,notpassed=0 (8.81 min)
bartlettroscoe
force-pushed
the
2247-nox-thyra-heq-reduce-condition-number
branch
from
675b112 to
dc4f418
Compare
bartlettroscoe
added
AT: RETEST
|
Status Flag 'Pull Request AutoTester' - User Requested Retest - Resetting Testing Status |
trilinos-autotester
removed
the
AT: RETEST
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_autotester_test
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Using Repos:
Pull Request Author: bartlettroscoe |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_autotester_test
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reduces the condition number of the least-squares problem from
10^12 to 10^4 and results in more stable floating point computations and
better portability of the test.
This fixes the failures with the Intel compiler 17.0.1 with optimized compiler
flags (see #2247).
Also has to change number of expected iterations from 18 to 11.
I tested this with Intel and GNU builds and they both passed:
Enabled Packages: NOX
Enabled all Forward Packages