Fix #2319: MueLu research build #2326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
, TRIL-171) EMPIRE does not build or test these examples and they don't currently build (see trilinos#2318). This just removes the clutter on CDash while these things can be fixed offline so that we can focus on the remaining failures.
After talking wit Si H., he said that hansen and shiller are Haswell not Boradwell.
This reverts commit 506af3b. Build/Test Cases Summary Enabled Packages: MueLu Enabled all Forward Packages 0) MPI_RELEASE_DEBUG_SHARED_PT => passed: passed=495,notpassed=0 (91.93 min)
mayrmt
added
pkg: MueLu
stage: in review
bartlettroscoe
removed
the
stage: in review
|
I accidentally chose |
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_autotester_test
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Using Repos:
Pull Request Author: mayrmt |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_autotester_test
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
bartlettroscoe
approved these changes
Mar 3, 2018
There was a problem hiding this comment.
@mayrmt, I am not a MueLu developer but this looks like you are just removing a test and the source file muelu/research/luc/region_algorithms/Import.cpp and a test that builds this source file.
It looks like this will clean up one of the link failures for #2319 but I don't see how it is going to resolve the other 5 link failures that don't seem to involve this file or this test.
Therefore, I removed the "Closes #2319" in the first comment of this PR because I don't think this is going to fix all of the MueLu build failures for that CUDA build.
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ bartlettroscoe ]! |
|
Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Master Automerge is disabled (in .cfg file) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revert 506af3b to fix build errors with
MueLu_ENABLE_Experimental=ONRelated Issues
How Has This Been Tested?
I used
checkin-test.pyto push to the feature branch of my fork following the instructions in #2295.