Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piro: before adding observer to Tempus, first clear the composite vector #2189

Merged
merged 1 commit into from
Jan 26, 2018

Conversation

sconde
Copy link
Contributor

@sconde sconde commented Jan 25, 2018

when setting tempus observer, first clear the vector of observers to avoid adding multiple copies of the piro tempus obsevers.

also define integrator output in TempusObserver here since the composite
vector is cleared.

@trilinos/piro @trilinos/tempus

Related Issues

How Has This Been Tested?

NOTE: still need to be tested with Albany

Screenshots

Checklist

  • My commit messages mention the appropriate GitHub issue numbers.
  • My code follows the code style of the affected package(s).
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the code contribution guidelines for this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • No new compiler warnings were introduced.
  • These changes break backwards compatibility.

Additional Information

also define integrator output in TempusObserver here since the composite
vector is cleared.
@sconde sconde requested a review from ikalash January 25, 2018 21:49
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_autotester_test

  • Build Num: 338
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2189
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH piro-tempus-solver-observer-reset
TRILINOS_SOURCE_REPO https://github.com/sconde/Trilinos
TRILINOS_SOURCE_SHA 623a45b
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 7b49629

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

  • Build Num: 203
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.9.3
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2189
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH piro-tempus-solver-observer-reset
TRILINOS_SOURCE_REPO https://github.com/sconde/Trilinos
TRILINOS_SOURCE_SHA 623a45b
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 7b49629

Using Repos:

Repo: TRILINOS (sconde/Trilinos)
  • Branch: piro-tempus-solver-observer-reset
  • SHA: 623a45b
  • Mode: TEST_REPO

Pull Request Author: sconde

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_autotester_test

  • Build Num: 338
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2189
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH piro-tempus-solver-observer-reset
TRILINOS_SOURCE_REPO https://github.com/sconde/Trilinos
TRILINOS_SOURCE_SHA 623a45b
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 7b49629

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

  • Build Num: 203
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.9.3
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2189
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH piro-tempus-solver-observer-reset
TRILINOS_SOURCE_REPO https://github.com/sconde/Trilinos
TRILINOS_SOURCE_SHA 623a45b
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 7b49629

Copy link
Contributor

@ikalash ikalash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to fix the problem in Albany! Please go ahead and merge (or I can, if you prefer).

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ ikalash ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Master Automerge is disabled (in .cfg file)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants