Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tempus: (fix) output integrator info at interval specified #2168

Merged
merged 1 commit into from
Jan 19, 2018
Merged

Tempus: (fix) output integrator info at interval specified #2168

merged 1 commit into from
Jan 19, 2018

Conversation

sconde
Copy link
Contributor

@sconde sconde commented Jan 17, 2018

Was outputing at every time step and this could possibly have slowed down Albany's tests

Verbose output for the Explicit RK test before the fix vs
Verbose output for the Explicit RK test before the fix

@trilinos/tempus

Related Issues

How Has This Been Tested?

Checklist

  • My commit messages mention the appropriate GitHub issue numbers.
  • My code follows the code style of the affected package(s).
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the code contribution guidelines for this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • No new compiler warnings were introduced.
  • These changes break backwards compatibility.

Additional Information

Tempus: (fix) output integrator info at interval specified
b81a380 
Was outputing at every time step and this slowed down tests
@sconde sconde requested a review from ikalash January 17, 2018 16:42
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_autotester_test

  • Build Num: 327
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2168
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tempus-verbose-output-interval
TRILINOS_SOURCE_REPO https://github.com/sconde/Trilinos
TRILINOS_SOURCE_SHA b81a380
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA c6c840d

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

  • Build Num: 192
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.9.3
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2168
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tempus-verbose-output-interval
TRILINOS_SOURCE_REPO https://github.com/sconde/Trilinos
TRILINOS_SOURCE_SHA b81a380
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA c6c840d

Using Repos:

Repo: TRILINOS (sconde/Trilinos)
  • Branch: tempus-verbose-output-interval
  • SHA: b81a380
  • Mode: TEST_REPO

Pull Request Author: sconde

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_autotester_test

  • Build Num: 327
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2168
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tempus-verbose-output-interval
TRILINOS_SOURCE_REPO https://github.com/sconde/Trilinos
TRILINOS_SOURCE_SHA b81a380
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA c6c840d

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

  • Build Num: 192
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.9.3
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2168
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tempus-verbose-output-interval
TRILINOS_SOURCE_REPO https://github.com/sconde/Trilinos
TRILINOS_SOURCE_SHA b81a380
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA c6c840d

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@ikalash
Copy link
Contributor

ikalash commented Jan 17, 2018

@sconde : I just pulled / built this branch of Trilinos and build Albany on top of it. Unfortunately it does not seem to fix issues #2163 and https://github.com/gahansen/Albany/issues/243 . Here is the time with your fix for the test:

Start 1: Schwarz_Alternating_Dynamics_Cubes
Test #1: Schwarz_Alternating_Dynamics_Cubes ............ Passed 103.77 sec

Would it be helpful for you to be able to run Albany to reproduce the problem? I could give you an account on my workstation (I assume you have SRN access) where I have scripts to build both Albany and Trilinos if you wanted to play around there.

@sconde
Copy link
Contributor Author

sconde commented Jan 17, 2018

@ikalash Is it possible to get a copy of your build script? I can build Albany on my workstation (if I can access it). This way I will make sure to always test with Albany in the future.

If not, I have SRN access if you want to give me an account on your machine.

@ikalash
Copy link
Contributor

ikalash commented Jan 17, 2018

Yes, absolutely, I'm happy to share my build scripts and build instructions (and if you can test major changes against Albany that would be great!). I will follow up with you offline (through email) later today. Question: do you have sems modules on your workstation? If so, I'll send you instructions for building with them. It should be very straightforward.

@sconde
Copy link
Contributor Author

sconde commented Jan 17, 2018

Yes, I build with SEMS. Thank you so much.

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

ccober6
ccober6 approved these changes Jan 18, 2018
View reviewed changes
Copy link
Contributor

@ccober6 ccober6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ ccober6 ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Master Automerge is disabled (in .cfg file)

1 similar comment
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Master Automerge is disabled (in .cfg file)

@sconde sconde merged commit f9c3a6c into trilinos:develop Jan 19, 2018
@sconde sconde deleted the tempus-verbose-output-interval branch January 25, 2018 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccober6 ccober6 ccober6 approved these changes

@ikalash ikalash Awaiting requested review from ikalash

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sconde @trilinos-autotester @ikalash @ccober6