Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix spelling errors in tpetra #1956

Closed
wants to merge 1 commit into from
Closed

fix spelling errors in tpetra #1956

wants to merge 1 commit into from

Conversation

nschloe
Copy link
Member

@nschloe nschloe commented Nov 4, 2017

No description provided.

@bartlettroscoe bartlettroscoe added the stage: in progress Work on the issue has started label Nov 4, 2017
Copy link
Contributor

@mhoemmen mhoemmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; thanks!

I can't merge into master; I could merge into Trilinos:develop, though. Please don't trouble yourself with redoing this to base against develop; I'll just make the changes by hand. Thanks again!

@nschloe
Copy link
Member Author

nschloe commented Nov 5, 2017

Ah, I forgot which one of master and develop to take a base branch and which as target. Perhaps these can be aligned in the future to make it easier to contribute. Till then, just rebase/merge to whatever you need. Thanks!

mhoemmen pushed a commit that referenced this pull request Nov 6, 2017
@trilinos/tpetra Thanks to @nschloe for contributing fixes.
@mhoemmen
Copy link
Contributor

mhoemmen commented Nov 6, 2017

I just applied your fixes to Tpetra:develop in commit 19f80d5 . Thanks @nschloe !

@mhoemmen mhoemmen closed this Nov 6, 2017
@mhoemmen mhoemmen removed the stage: in progress Work on the issue has started label Nov 6, 2017
ndellingwood added a commit to ndellingwood/Trilinos that referenced this pull request Nov 7, 2017
* develop: (812 commits)
  MueLu: comment out mmayr research subdirectory
  Enable Tacho in Kokkos promotion configuration
  Shylu/Tacho - fix the unit test failure described in trilinos#1935
  Tpetra: Fix spelling errors (see trilinos#1956)
  Intrepid2: implementing new design suggested by Kyungjoo to have work view of rank 1, instead of having a work view of rank 2 or 3.            In this case we have to expose Fad dimension.
  Intrepid2: introduce new function get_dimension_scalar(view) that returns the dimension_scalar(view),                for non pod view types (defined e.g. in Sacado) and returns 1 for pod types.
  HHG: 1D test code to figure out issues with parallelism
  MueLu tutorial: correct instructions in README file
  MueLu/HHG: setup row maps for each region
  MueLu/HHG: setup data structure to store all nodes in each region
  MueLu/HHG: read proc info from file
  MueLu/HHG: write region matrix information to file (using Matlab)
  MueLu/HHG: attempt to fix indices
  MueLu/HHG: First draft of regional splitting of matrices
  MueLu/HHG by Max: move creation of Xpetra::MatrixSplitting to driver
  MueLu/HHG by Max: move creation of RegionHandler to Test_xpetra.cpp
  Single versus double colon.
  Fixed FS example.
  ShyLU: Add missing TRIBITS_PACKAGE_DEF() calls (TriBITSPub/TriBITS#200)
  Enable ST code in ST extrab builds
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants