Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tpetra: mask some code that SWIG parser hiccups on #1885

Merged
merged 1 commit into from
Oct 23, 2017
Merged

Tpetra: mask some code that SWIG parser hiccups on #1885

merged 1 commit into from
Oct 23, 2017

Conversation

aprokop
Copy link
Contributor

@aprokop aprokop commented Oct 20, 2017

@trilinos/tpetra

@aprokop aprokop added the stage: in progress Work on the issue has started label Oct 20, 2017
@mhoemmen mhoemmen self-requested a review October 22, 2017 20:42
mhoemmen
mhoemmen approved these changes Oct 22, 2017
View reviewed changes
Copy link
Contributor

@mhoemmen mhoemmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'm guessing that SWIG doesn't need access to this private field. How does one test correctness of SWIG's Tpetra interface?

@aprokop
Copy link
Contributor Author

aprokop commented Oct 23, 2017

@mhoemmen Thanks for the review!

I'm guessing that SWIG doesn't need access to this private field.

Yeah. The problem is that SWIG implements its own parser, and it is not as robust as a compiler one, extra brackets and other things may confuse it.

How does one test correctness of SWIG's Tpetra interface?

Not sure what you mean here. If you are talking about testing the PyTrilinos or ForTrilinos Tpetra generated interfaces, then that is still an open question, as I currently see no way to wrap tests.

@mhoemmen mhoemmen merged commit 9b01088 into trilinos:develop Oct 23, 2017
@mhoemmen mhoemmen removed the stage: in progress Work on the issue has started label Oct 23, 2017
@mhoemmen
Copy link
Contributor

@aprokop Thanks for the clarification!

@aprokop aprokop deleted the tpetra_swig branch October 23, 2017 16:10
@trilinos-autotester trilinos-autotester mentioned this pull request Mar 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhoemmen mhoemmen mhoemmen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Tpetra
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aprokop @mhoemmen