Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shylubasker runtime trsolve #12617

Merged
merged 15 commits into from
Jan 8, 2024
Merged

Shylubasker runtime trsolve #12617

merged 15 commits into from
Jan 8, 2024

Conversation

ndellingwood
Copy link
Contributor

@trilinos/shylu @iyamazaki @hkthorn

Motivation

  • Add runtime transpose solve routine
  • Fixups for threaded factorization (thanks @iyamazaki !)

Stakeholder Feedback

Testing

  • Local testing with gcc/10.4 OpenMP build
  • Preliminary testing with Xyce test suite matrices

Additional Information

ndellingwood and others added 15 commits December 19, 2023 17:35
@ndellingwood
shylubasker: runtime transpose solve checkin
379e720
@iyamazaki @ndellingwood
ShyLU-Basker : apply *inverse* permutation for transpose solve
b92d20f
@ndellingwood
basker: tr solve verbose output cleanup
fce5b6d
@iyamazaki @ndellingwood
ShyLUBasker : initial transpose-solve patch
2896ebb
@iyamazaki @ndellingwood
ShyLU-Basker : adjust threshold to decide on a big A block
3755214
@iyamazaki @ndellingwood
ShyLU-Basker : trying to remove assumption that we do ND if nblk == 1
7768902
@iyamazaki @ndellingwood
ShyLU-Basker : removing the commented code from the previous commit
4b5f874
@iyamazaki @ndellingwood
ShyLU-Basker : some numerical enhancement
8e3b2d3 
 > add explicit tiny pivot for zero L column in domain fact
 > return error code from separator fact
@iyamazaki @ndellingwood
ShyLU-Basker : adjust threshold so that ND facto only if the block si…
8a0a0eb 
…ze > 20 * num-threads
@iyamazaki @ndellingwood
ShyLU-Basker : remove some debugging printf statements
cd0ef81
@ndellingwood
shylubasker: some cleanup
402efce
@ndellingwood
amesos2: temp commit for shylubasker runtime tr solve testing
146e6eb 
To enable, use the parameter list option "runtime_transpose"
@ndellingwood
shylubasker: remove transpose solve dev debug blocks
64c5233
@ndellingwood
Revert "amesos2: temp commit for shylubasker runtime tr solve testing"
d6ef7f1 
This reverts commit 146e6eb.
@ndellingwood
amesos2: remove stray line missed during revert (due to past rebase)
b69168a
@ndellingwood ndellingwood added pkg: ShyLU AT: WIP Causes the PR autotester to not test the PR. (Remove to allow testing to occur.) labels Dec 20, 2023
@ndellingwood ndellingwood requested a review from a team as a code owner December 20, 2023 01:40
@ndellingwood
Copy link
Contributor Author

@iyamazaki @hkthorn when either of you get a moment could you give this PR a glance? Thanks!

@iyamazaki
Copy link
Contributor

Thank you for pushing this through, @ndellingwood!! We've gone through the changes, and they have passes our local tests. So, I am okay with the changes.

It looks like this PR does not contain any Amesos2 updates, so this option is not available through Amesos2 interface, yet? Does that come with the follow-up PR (to skip the transpose setups)?

@ndellingwood
Copy link
Contributor Author

@iyamazaki yes, I plan to add the Amesos2 PR as a follow on to these change

@ndellingwood ndellingwood removed the AT: WIP Causes the PR autotester to not test the PR. (Remove to allow testing to occur.) label Jan 8, 2024
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

  • Build Num: 3508
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: ShyLU
PULLREQUESTNUM 12617
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/ndellingwood/Trilinos
TRILINOS_SOURCE_SHA b69168a
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 938ec4a

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

  • Build Num: 2007
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: ShyLU
PULLREQUESTNUM 12617
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/ndellingwood/Trilinos
TRILINOS_SOURCE_SHA b69168a
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 938ec4a

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

  • Build Num: 1997
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: ShyLU
PULLREQUESTNUM 12617
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/ndellingwood/Trilinos
TRILINOS_SOURCE_SHA b69168a
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 938ec4a

Build Information

Test Name: Trilinos_PR_clang-11.0.1

  • Build Num: 1996
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: ShyLU
PULLREQUESTNUM 12617
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/ndellingwood/Trilinos
TRILINOS_SOURCE_SHA b69168a
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 938ec4a

Build Information

Test Name: Trilinos_PR_python3

  • Build Num: 3182
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS pkg: ShyLU
PULLREQUESTNUM 12617
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL ascic
TRILINOS_SOURCE_REPO https://github.com/ndellingwood/Trilinos
TRILINOS_SOURCE_SHA b69168a
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 938ec4a

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

  • Build Num: 2999
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: ShyLU
PULLREQUESTNUM 12617
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL GPU
TRILINOS_SOURCE_REPO https://github.com/ndellingwood/Trilinos
TRILINOS_SOURCE_SHA b69168a
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 938ec4a

Build Information

Test Name: Trilinos_PR_intel-2021.3

  • Build Num: 1638
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-off_no-package-enables
PR_LABELS pkg: ShyLU
PULLREQUESTNUM 12617
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/ndellingwood/Trilinos
TRILINOS_SOURCE_SHA b69168a
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 938ec4a

Using Repos:

Repo: TRILINOS (ndellingwood/Trilinos)
  • Branch: shylubasker-runtime-trsolve
  • SHA: b69168a
  • Mode: TEST_REPO

Pull Request Author: ndellingwood

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

  • Build Num: 3508
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: ShyLU
PULLREQUESTNUM 12617
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/ndellingwood/Trilinos
TRILINOS_SOURCE_SHA b69168a
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 938ec4a

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

  • Build Num: 2007
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: ShyLU
PULLREQUESTNUM 12617
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/ndellingwood/Trilinos
TRILINOS_SOURCE_SHA b69168a
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 938ec4a

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

  • Build Num: 1997
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: ShyLU
PULLREQUESTNUM 12617
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/ndellingwood/Trilinos
TRILINOS_SOURCE_SHA b69168a
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 938ec4a

Build Information

Test Name: Trilinos_PR_clang-11.0.1

  • Build Num: 1996
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: ShyLU
PULLREQUESTNUM 12617
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/ndellingwood/Trilinos
TRILINOS_SOURCE_SHA b69168a
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 938ec4a

Build Information

Test Name: Trilinos_PR_python3

  • Build Num: 3182
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS pkg: ShyLU
PULLREQUESTNUM 12617
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL ascic
TRILINOS_SOURCE_REPO https://github.com/ndellingwood/Trilinos
TRILINOS_SOURCE_SHA b69168a
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 938ec4a

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

  • Build Num: 2999
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: ShyLU
PULLREQUESTNUM 12617
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL GPU
TRILINOS_SOURCE_REPO https://github.com/ndellingwood/Trilinos
TRILINOS_SOURCE_SHA b69168a
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 938ec4a

Build Information

Test Name: Trilinos_PR_intel-2021.3

  • Build Num: 1638
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-off_no-package-enables
PR_LABELS pkg: ShyLU
PULLREQUESTNUM 12617
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/ndellingwood/Trilinos
TRILINOS_SOURCE_SHA b69168a
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 938ec4a


CDash Test Results for PR# 12617.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ iyamazaki ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR...

@ndellingwood ndellingwood merged commit 18524ec into trilinos:develop Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iyamazaki iyamazaki iyamazaki approved these changes

@hkthorn hkthorn Awaiting requested review from hkthorn

Assignees
No one assigned
Labels
pkg: ShyLU
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndellingwood @iyamazaki @trilinos-autotester