Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Framework: Update detect-mpi-comm-world GitHub action #12199

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Framework: Update detect-mpi-comm-world GitHub action #12199

merged 2 commits into from
Sep 7, 2023

Conversation

JacobDomagala
Copy link
Contributor

@trilinos/framework

Fix the issue where base branch is out of sync with Trilinos' develop branch. This results in false positives (removed files or removed lines of MPI_COMM_WORLD are reported since they're still present on base branch).

I also removed the local (uncommited) execution part, since it can produce incorrect results.

@JacobDomagala JacobDomagala self-assigned this Sep 2, 2023
@JacobDomagala JacobDomagala mentioned this pull request Sep 2, 2023
Merged
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

@sebrowne
Copy link
Contributor

sebrowne commented Sep 2, 2023

Using the merge base makes sense to me, this is what I've done on a couple of other projects.

@sebrowne sebrowne added the AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. label Sep 2, 2023
@trilinos-autotester trilinos-autotester removed the AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. label Sep 2, 2023
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
ERROR: LABEL SET BY UNAPPROVED USER 'sebrowne', INSPECTION IS INVALID! - This PR must be re-inspected by approved user.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

@sebrowne sebrowne added the AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. label Sep 5, 2023
@trilinos-autotester trilinos-autotester removed the AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. label Sep 5, 2023
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; this inspection will remain valid until a new commit to source branch is performed.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

  • Build Num: 2779
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 12199
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA 28b83bd
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 73dcc21

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

  • Build Num: 1278
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 12199
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA 28b83bd
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 73dcc21

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

  • Build Num: 1268
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 12199
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA 28b83bd
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 73dcc21

Build Information

Test Name: Trilinos_PR_clang-11.0.1

  • Build Num: 1267
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 12199
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA 28b83bd
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 73dcc21

Build Information

Test Name: Trilinos_PR_python3

  • Build Num: 2482
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS
PULLREQUESTNUM 12199
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL ascic
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA 28b83bd
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 73dcc21

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

  • Build Num: 2270
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 12199
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL GPU
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA 28b83bd
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 73dcc21

Build Information

Test Name: Trilinos_PR_intel-2021.3

  • Build Num: 909
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-off_no-package-enables
PR_LABELS
PULLREQUESTNUM 12199
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA 28b83bd
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 73dcc21

Using Repos:

Repo: TRILINOS (NexGenAnalytics/Trilinos)
  • Branch: framework-update-mpi-comm-world-github-action
  • SHA: 28b83bd
  • Mode: TEST_REPO

Pull Request Author: JacobDomagala

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

  • Build Num: 2779
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 12199
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA 28b83bd
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 73dcc21

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

  • Build Num: 1278
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 12199
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA 28b83bd
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 73dcc21

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

  • Build Num: 1268
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 12199
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA 28b83bd
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 73dcc21

Build Information

Test Name: Trilinos_PR_clang-11.0.1

  • Build Num: 1267
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 12199
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA 28b83bd
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 73dcc21

Build Information

Test Name: Trilinos_PR_python3

  • Build Num: 2482
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS
PULLREQUESTNUM 12199
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL ascic
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA 28b83bd
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 73dcc21

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

  • Build Num: 2270
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM 12199
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL GPU
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA 28b83bd
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 73dcc21

Build Information

Test Name: Trilinos_PR_intel-2021.3

  • Build Num: 909
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-off_no-package-enables
PR_LABELS
PULLREQUESTNUM 12199
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/NexGenAnalytics/Trilinos
TRILINOS_SOURCE_SHA 28b83bd
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 73dcc21


CDash Test Results for PR# 12199.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ sebrowne ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR...

1 similar comment
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR...

@mperego mperego mentioned this pull request Sep 6, 2023
Merged
@cgcgcg
Copy link
Contributor

cgcgcg commented Sep 7, 2023

@JacobDomagala @sebrowne Can this be merged?

@sebrowne
Copy link
Contributor

sebrowne commented Sep 7, 2023

Works for me

@jwillenbring jwillenbring merged commit 3278a76 into trilinos:develop Sep 7, 2023
@sebrowne sebrowne mentioned this pull request Sep 7, 2023
Merged
jgfouca added a commit to jgfouca/Trilinos that referenced this pull request Sep 7, 2023
@jgfouca
Merge remote-tracking branch 'origin/develop' into jgfouca/measure_fa…
9dfa45f 
…stilu

* origin/develop: (179 commits)
  Framework: Update `detect-mpi-comm-world` GitHub action (trilinos#12199)
  Ifpack2: fix dashboard failures in MDF unit tests (trilinos#12217)
  teuchos(cleaning): remove old type traits is_same
  Use ternary in conditionals involving is_contiguous.
  Extract diagonal blocks from a CRS matrix into separate CRS matrices
  Tpetra: Update Building.rst
  Zoltan2: fix shadow warning
  Stokhos: fix KokkosKernels trilinos#1959
  NOX: fix font in screen output
  Tpetra: fix TAFC changes for UVM enabled
  Tpetra: remove unnecessary exception test
  MueLu: remove deep_copy timers
  Tpetra: fix unit tests, eliminate more deep copies
  Tpetra: remove obsolete TAFC method
  Tpetra: merge two TAFC methods
  MueLu: update lumped diagonal code
  Tpetra: replace device type of resulting view
  Belos: Remove use of hardcoded MPI_COMM_WORLD
  Stokhos: update for new KokkosSparse::spmv overloads
  Tpetra: Removing the incorrect ETI_DEVICES
  ...
jmgate pushed a commit to tcad-charon/Trilinos that referenced this pull request Sep 8, 2023
Merge 'trilinos/Trilinos:develop' (7057688) into 'tcad-charon/Trilino…
e7bf71f 
…s:develop' (9cf8dfb).

* trilinos-develop:
  Framework: Update `detect-mpi-comm-world` GitHub action (trilinos#12199)
  Ifpack2: fix dashboard failures in MDF unit tests (trilinos#12217)
  teuchos(cleaning): remove old type traits is_same
  Remove LFS image objects
  Use ternary in conditionals involving is_contiguous.
  Zoltan2: fix shadow warning
  Belos: Remove use of hardcoded MPI_COMM_WORLD
  Zoltan2: Fix warnings and formatting
  Zoltan2: Refactor of BasisVectorAdapter to use Kokkos data structures
jmgate pushed a commit to tcad-charon/Trilinos that referenced this pull request Sep 8, 2023
Merge 'trilinos/Trilinos:develop' (7057688) into 'tcad-charon/Trilino…
4146516 
…s:develop' (9cf8dfb).

* trilinos-develop:
  Framework: Update `detect-mpi-comm-world` GitHub action (trilinos#12199)
  Ifpack2: fix dashboard failures in MDF unit tests (trilinos#12217)
  teuchos(cleaning): remove old type traits is_same
  Remove LFS image objects
  Use ternary in conditionals involving is_contiguous.
  Zoltan2: fix shadow warning
  Belos: Remove use of hardcoded MPI_COMM_WORLD
  Zoltan2: Fix warnings and formatting
  Zoltan2: Refactor of BasisVectorAdapter to use Kokkos data structures
@stmcgovern stmcgovern mentioned this pull request Sep 8, 2023
Closed
sebrowne pushed a commit to sebrowne/Trilinos that referenced this pull request Sep 11, 2023
@JacobDomagala @sebrowne
Framework: Update detect-mpi-comm-world GitHub action (trilinos#12199)
4554ecd 
* Framework: Fix issue with detect-mpi-comm-world.yml when base branch is out of sync with origin/develop

* Framework: Remove check for uncommited changes from the check-mpi-comm-world-usage script, as it may provide incorrect output
sebrowne pushed a commit to sebrowne/Trilinos that referenced this pull request Sep 11, 2023
@jgfouca @sebrowne
Merge remote-tracking branch 'origin/develop' into jgfouca/measure_fa…
81ccf43 
…stilu

* origin/develop: (179 commits)
  Framework: Update `detect-mpi-comm-world` GitHub action (trilinos#12199)
  Ifpack2: fix dashboard failures in MDF unit tests (trilinos#12217)
  teuchos(cleaning): remove old type traits is_same
  Use ternary in conditionals involving is_contiguous.
  Extract diagonal blocks from a CRS matrix into separate CRS matrices
  Tpetra: Update Building.rst
  Zoltan2: fix shadow warning
  Stokhos: fix KokkosKernels trilinos#1959
  NOX: fix font in screen output
  Tpetra: fix TAFC changes for UVM enabled
  Tpetra: remove unnecessary exception test
  MueLu: remove deep_copy timers
  Tpetra: fix unit tests, eliminate more deep copies
  Tpetra: remove obsolete TAFC method
  Tpetra: merge two TAFC methods
  MueLu: update lumped diagonal code
  Tpetra: replace device type of resulting view
  Belos: Remove use of hardcoded MPI_COMM_WORLD
  Stokhos: update for new KokkosSparse::spmv overloads
  Tpetra: Removing the incorrect ETI_DEVICES
  ...
sebrowne pushed a commit to sebrowne/Trilinos that referenced this pull request Sep 11, 2023
@JacobDomagala
Framework: Update detect-mpi-comm-world GitHub action (trilinos#12199)
db3b4c9 
* Framework: Fix issue with detect-mpi-comm-world.yml when base branch is out of sync with origin/develop

* Framework: Remove check for uncommited changes from the check-mpi-comm-world-usage script, as it may provide incorrect output
sebrowne pushed a commit to sebrowne/Trilinos that referenced this pull request Sep 11, 2023
@jgfouca
Merge remote-tracking branch 'origin/develop' into jgfouca/measure_fa…
384e0d6 
…stilu

* origin/develop: (179 commits)
  Framework: Update `detect-mpi-comm-world` GitHub action (trilinos#12199)
  Ifpack2: fix dashboard failures in MDF unit tests (trilinos#12217)
  teuchos(cleaning): remove old type traits is_same
  Use ternary in conditionals involving is_contiguous.
  Extract diagonal blocks from a CRS matrix into separate CRS matrices
  Tpetra: Update Building.rst
  Zoltan2: fix shadow warning
  Stokhos: fix KokkosKernels trilinos#1959
  NOX: fix font in screen output
  Tpetra: fix TAFC changes for UVM enabled
  Tpetra: remove unnecessary exception test
  MueLu: remove deep_copy timers
  Tpetra: fix unit tests, eliminate more deep copies
  Tpetra: remove obsolete TAFC method
  Tpetra: merge two TAFC methods
  MueLu: update lumped diagonal code
  Tpetra: replace device type of resulting view
  Belos: Remove use of hardcoded MPI_COMM_WORLD
  Stokhos: update for new KokkosSparse::spmv overloads
  Tpetra: Removing the incorrect ETI_DEVICES
  ...
csiefer2 pushed a commit that referenced this pull request Sep 12, 2023
@JacobDomagala @csiefer2
Framework: Update detect-mpi-comm-world GitHub action (#12199)
c6c7b03 
* Framework: Fix issue with detect-mpi-comm-world.yml when base branch is out of sync with origin/develop

* Framework: Remove check for uncommited changes from the check-mpi-comm-world-usage script, as it may provide incorrect output
cwpearson pushed a commit to cwpearson/Trilinos that referenced this pull request Sep 19, 2023
@JacobDomagala @cwpearson
Framework: Update detect-mpi-comm-world GitHub action (trilinos#12199)
1fac690 
* Framework: Fix issue with detect-mpi-comm-world.yml when base branch is out of sync with origin/develop

* Framework: Remove check for uncommited changes from the check-mpi-comm-world-usage script, as it may provide incorrect output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebrowne sebrowne sebrowne approved these changes

Assignees

@JacobDomagala JacobDomagala

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JacobDomagala @trilinos-autotester @sebrowne @cgcgcg @jwillenbring