sacado(cleaning): removing old CXX11 related macros #11915

romintomasetti · 2023-05-25T07:33:10Z

@trilinos/Sacado

Motivation

This PR is an extract from #11912 and is a simple cleaning of outdated CXX11 stuff in Sacado (since C++17 is now a requirement).

Related Issues

tpetra(CrsMatrix): stop relying on raw pointers to support more complex scalar types #11912

packages/sacado/src/Sacado_ConfigDefs.h

packages/sacado/src/Sacado_cmath.hpp

packages/sacado/src/mpl/Sacado_mpl_is_convertible.hpp

trilinos-autotester · 2023-05-25T10:04:51Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

romintomasetti · 2023-05-30T07:01:54Z

@etphipp I'm done ;) However, I pushed a new commit that dismissed your review 👼

etphipp

Looks good, thanks!

romintomasetti · 2023-06-02T07:40:17Z

@etphipp I guess we are missing LABEL 'AT: PRE-TEST INSPECTED' NOT SET for triggering the pipeline?

etphipp · 2023-06-05T17:10:18Z

I added the labels.

trilinos-autotester · 2023-06-05T17:29:48Z

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; This inspection will remain valid until a new commit to source branch is performed.

trilinos-autotester · 2023-06-05T17:31:41Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Build Num: 2332
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: AUTOMERGE
PULLREQUESTNUM	11915
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	sacado-remove-old-cxx11
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`9f0c370`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`9e6a21d`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Build Num: 860
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: AUTOMERGE
PULLREQUESTNUM	11915
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	sacado-remove-old-cxx11
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`9f0c370`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`9e6a21d`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Build Num: 852
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: AUTOMERGE
PULLREQUESTNUM	11915
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	sacado-remove-old-cxx11
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`9f0c370`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`9e6a21d`

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Build Num: 851
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: AUTOMERGE
PULLREQUESTNUM	11915
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	sacado-remove-old-cxx11
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`9f0c370`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`9e6a21d`

Build Information

Test Name: Trilinos_PR_python3

Build Num: 2078
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS	AT: AUTOMERGE
PULLREQUESTNUM	11915
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	ascic
TRILINOS_SOURCE_BRANCH	sacado-remove-old-cxx11
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`9f0c370`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`9e6a21d`

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Build Num: 1853
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: AUTOMERGE
PULLREQUESTNUM	11915
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	GPU
TRILINOS_SOURCE_BRANCH	sacado-remove-old-cxx11
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`9f0c370`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`9e6a21d`

Build Information

Test Name: Trilinos_PR_intel-2021.3

Build Num: 491
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: AUTOMERGE
PULLREQUESTNUM	11915
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	sacado-remove-old-cxx11
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`9f0c370`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`9e6a21d`

Using Repos:

Repo: TRILINOS (uliegecsm/Trilinos)

Pull Request Author: romintomasetti

trilinos-autotester · 2023-06-05T20:36:09Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED

Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run.

Pull Request Auto Testing has FAILED (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Build Num: 2332
Status: FAILED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: AUTOMERGE
PULLREQUESTNUM	11915
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	sacado-remove-old-cxx11
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`9f0c370`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`9e6a21d`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Build Num: 860
Status: FAILED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: AUTOMERGE
PULLREQUESTNUM	11915
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	sacado-remove-old-cxx11
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`9f0c370`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`9e6a21d`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Build Num: 852
Status: FAILED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: AUTOMERGE
PULLREQUESTNUM	11915
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	sacado-remove-old-cxx11
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`9f0c370`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`9e6a21d`

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Build Num: 851
Status: FAILED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: AUTOMERGE
PULLREQUESTNUM	11915
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	sacado-remove-old-cxx11
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`9f0c370`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`9e6a21d`

Build Information

Test Name: Trilinos_PR_python3

Build Num: 2078
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS	AT: AUTOMERGE
PULLREQUESTNUM	11915
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	ascic
TRILINOS_SOURCE_BRANCH	sacado-remove-old-cxx11
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`9f0c370`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`9e6a21d`

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Build Num: 1853
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: AUTOMERGE
PULLREQUESTNUM	11915
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	GPU
TRILINOS_SOURCE_BRANCH	sacado-remove-old-cxx11
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`9f0c370`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`9e6a21d`

Build Information

Test Name: Trilinos_PR_intel-2021.3

Build Num: 491
Status: FAILED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: AUTOMERGE
PULLREQUESTNUM	11915
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	sacado-remove-old-cxx11
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`9f0c370`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`9e6a21d`

CDash Test Results for PR# 11915.

Wiki: How to Reproduce PR Testing Builds and Errors.

etphipp · 2023-06-05T20:44:47Z

@romintomasetti not sure if you can see the CDash output, but there are numerous build errors about not being able to find std::is_same. Looks like an include of <typetraits> is necessary.

trilinos-autotester · 2023-06-06T13:04:16Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

etphipp · 2023-06-06T15:16:03Z

@romintomasetti What changes did you just make and why did you have to force-push (as opposed to just adding a new commit)?

romintomasetti · 2023-06-06T15:40:24Z

@etphipp This is something I do all the time when working alone on a feature branch. I like having a clean git history.

See for instance https://www.caichinger.com/blog/2022/10/04/git_best_practices/.

In this case for instance, I didn't wanted to have a commit with the missing include. So I added the change, amended it and needed to force push.

Note that this method shouldn't impact the reviewer in general if you use the review functionalities of GitHub to mark files you reviewed and agreed. See for instance https://github.blog/2019-07-01-mark-files-as-viewed/ 😉

etphipp · 2023-06-07T15:58:38Z

There is nothing wrong with adding a second commit. I'm not seeing what changes you made to resolve the build errors.

romintomasetti · 2023-06-08T08:19:39Z

@etphipp I think my big mistake here is that I forced pushed not only my modification but also a rebase on the current develop branch... My bad sorry!

My only relevant change is that I needed to include type_traits in packages/sacado/src/mpl/Sacado_mpl_find.hpp as you suggested 😄

etphipp · 2023-06-08T15:50:47Z

I think you should add #include <typetraits> to any file that had included Sacado_mpl_is_same.hpp previously to make sure std::is_same<> is available, as opposed to relying on it coming in through Sacado_mpl_find.hpp. Some applications only include a subset of the Sacado headers and as it is now might cause problems for them.

romintomasetti · 2023-06-08T16:02:40Z

@etphipp Indeed, and done 😉

trilinos-autotester · 2023-06-08T18:01:28Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

trilinos-autotester · 2023-06-08T18:28:50Z

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; This inspection will remain valid until a new commit to source branch is performed.

trilinos-autotester · 2023-06-08T18:30:34Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Build Num: 2354
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: AUTOMERGE
PULLREQUESTNUM	11915
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	sacado-remove-old-cxx11
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`69ad15b`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`46ded0b`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Build Num: 882
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: AUTOMERGE
PULLREQUESTNUM	11915
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	sacado-remove-old-cxx11
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`69ad15b`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`46ded0b`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Build Num: 874
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: AUTOMERGE
PULLREQUESTNUM	11915
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	sacado-remove-old-cxx11
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`69ad15b`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`46ded0b`

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Build Num: 873
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: AUTOMERGE
PULLREQUESTNUM	11915
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	sacado-remove-old-cxx11
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`69ad15b`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`46ded0b`

Build Information

Test Name: Trilinos_PR_python3

Build Num: 2100
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS	AT: AUTOMERGE
PULLREQUESTNUM	11915
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	ascic
TRILINOS_SOURCE_BRANCH	sacado-remove-old-cxx11
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`69ad15b`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`46ded0b`

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Build Num: 1875
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: AUTOMERGE
PULLREQUESTNUM	11915
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	GPU
TRILINOS_SOURCE_BRANCH	sacado-remove-old-cxx11
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`69ad15b`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`46ded0b`

Build Information

Test Name: Trilinos_PR_intel-2021.3

Build Num: 513
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: AUTOMERGE
PULLREQUESTNUM	11915
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	sacado-remove-old-cxx11
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`69ad15b`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`46ded0b`

Using Repos:

Repo: TRILINOS (uliegecsm/Trilinos)

Pull Request Author: romintomasetti

trilinos-autotester · 2023-06-08T21:03:16Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Build Num: 2354
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: AUTOMERGE
PULLREQUESTNUM	11915
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	sacado-remove-old-cxx11
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`69ad15b`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`46ded0b`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Build Num: 882
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: AUTOMERGE
PULLREQUESTNUM	11915
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	sacado-remove-old-cxx11
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`69ad15b`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`46ded0b`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Build Num: 874
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: AUTOMERGE
PULLREQUESTNUM	11915
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	sacado-remove-old-cxx11
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`69ad15b`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`46ded0b`

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Build Num: 873
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: AUTOMERGE
PULLREQUESTNUM	11915
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	sacado-remove-old-cxx11
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`69ad15b`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`46ded0b`

Build Information

Test Name: Trilinos_PR_python3

Build Num: 2100
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS	AT: AUTOMERGE
PULLREQUESTNUM	11915
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	ascic
TRILINOS_SOURCE_BRANCH	sacado-remove-old-cxx11
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`69ad15b`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`46ded0b`

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Build Num: 1875
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: AUTOMERGE
PULLREQUESTNUM	11915
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	GPU
TRILINOS_SOURCE_BRANCH	sacado-remove-old-cxx11
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`69ad15b`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`46ded0b`

Build Information

Test Name: Trilinos_PR_intel-2021.3

Build Num: 513
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: AUTOMERGE
PULLREQUESTNUM	11915
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	sacado-remove-old-cxx11
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`69ad15b`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`46ded0b`

CDash Test Results for PR# 11915.

trilinos-autotester · 2023-06-08T21:03:33Z

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ etphipp ]!

trilinos-autotester · 2023-06-08T21:03:41Z

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

trilinos-autotester · 2023-06-08T21:03:44Z

Merge on Pull Request# 11915: IS A SUCCESS - Pull Request successfully merged

romintomasetti commented May 25, 2023

View reviewed changes

packages/sacado/src/Sacado_ConfigDefs.h Show resolved Hide resolved

romintomasetti commented May 25, 2023

View reviewed changes

packages/sacado/src/Sacado_cmath.hpp Outdated Show resolved Hide resolved

romintomasetti commented May 25, 2023

View reviewed changes

packages/sacado/src/mpl/Sacado_mpl_is_convertible.hpp Outdated Show resolved Hide resolved

romintomasetti force-pushed the sacado-remove-old-cxx11 branch from 9f6c860 to 3ec7c1a Compare May 25, 2023 07:39

romintomasetti changed the title ~~sacado(tpetra): support for Tpetra matrix of Sacado::Fad::SFad~~ sacado(cleaning): removing old CXX11 related macros May 25, 2023

romintomasetti mentioned this pull request May 25, 2023

tpetra(CrsMatrix): stop relying on raw pointers to support more complex scalar types #11912

Open

etphipp previously approved these changes May 25, 2023

View reviewed changes

romintomasetti dismissed etphipp’s stale review via 425e051 May 25, 2023 15:40

romintomasetti force-pushed the sacado-remove-old-cxx11 branch 3 times, most recently from e940102 to 9f0c370 Compare May 25, 2023 16:02

etphipp previously approved these changes May 30, 2023

View reviewed changes

etphipp self-assigned this Jun 5, 2023

etphipp added AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. labels Jun 5, 2023

trilinos-autotester removed the AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. label Jun 5, 2023

romintomasetti dismissed etphipp’s stale review via 6433d63 June 6, 2023 12:38

romintomasetti force-pushed the sacado-remove-old-cxx11 branch from 9f0c370 to 6433d63 Compare June 6, 2023 12:38

sacado(cleaning): removing old CXX11 related macros

69ad15b

romintomasetti force-pushed the sacado-remove-old-cxx11 branch from 6433d63 to 69ad15b Compare June 8, 2023 16:01

etphipp approved these changes Jun 8, 2023

View reviewed changes

etphipp added the AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. label Jun 8, 2023

trilinos-autotester removed the AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. label Jun 8, 2023

trilinos-autotester merged commit 7e0c759 into trilinos:develop Jun 8, 2023

trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Jun 8, 2023

sacado(cleaning): removing old CXX11 related macros #11915

sacado(cleaning): removing old CXX11 related macros #11915

Conversation

romintomasetti commented May 25, 2023

Motivation

Related Issues

trilinos-autotester commented May 25, 2023

romintomasetti commented May 30, 2023

etphipp left a comment

Choose a reason for hiding this comment

romintomasetti commented Jun 2, 2023

etphipp commented Jun 5, 2023

trilinos-autotester commented Jun 5, 2023

trilinos-autotester commented Jun 5, 2023

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_python3

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_intel-2021.3

Jenkins Parameters

Using Repos:

trilinos-autotester commented Jun 5, 2023

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_python3

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_intel-2021.3

Jenkins Parameters

etphipp commented Jun 5, 2023

trilinos-autotester commented Jun 6, 2023

etphipp commented Jun 6, 2023

romintomasetti commented Jun 6, 2023

etphipp commented Jun 7, 2023

romintomasetti commented Jun 8, 2023

etphipp commented Jun 8, 2023

romintomasetti commented Jun 8, 2023

trilinos-autotester commented Jun 8, 2023

trilinos-autotester commented Jun 8, 2023

trilinos-autotester commented Jun 8, 2023

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_clang-11.0.1